Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dsconf / dscreate should be able to handle lmdb parameters #5843

Closed
progier389 opened this issue Jul 17, 2023 · 5 comments · Fixed by #5943
Closed

dsconf / dscreate should be able to handle lmdb parameters #5843

progier389 opened this issue Jul 17, 2023 · 5 comments · Fixed by #5943
Labels
CLI CLI tools lmdb LMDB related

Comments

@progier389
Copy link
Contributor

Issue Description
lmdb specific parameters should be visible in dsconf

Package Version and Platform:

  • Platform: Fedora
  • Package and version: main
  • Browser [e.g. chrome, safari]

Steps to Reproduce
Steps to reproduce the behavior:

  1. Configure an instance with lmdb
  2. Run dsconf supplier1 backend config set --help

Expected results
Should see the lmdb specific parameters like:

  • nsslapd-mdb-max-size
  • nsslapd-mdb-max-readers
  • nsslapd-mdb-max-dbs

Additional context
dscreate create-template should also propose the nsslapd-mdb-max-size as it is a critical parameter
dscreate interactive should ask for

  • the bdb/mdb mode
  • the mdb max size if in mdb mode
@progier389 progier389 added lmdb LMDB related CLI CLI tools needs triage The issue will be triaged during scrum labels Jul 17, 2023
@progier389
Copy link
Contributor Author

dscreate needs to be able to handle these parameters but we cannot change these value afterwards
without removing the whole db and recreating it ( lmdb limitation) so I do not think that dsconf should be changed.
we will have to describe how to change
see also issue #5844 that is related.

@Firstyear
Copy link
Contributor

Thinking more about this, I think that we shouldn't have a default size. We should always force the admin to select a size here. That way they are always aware of the choice they need to make and don't have a "surprise you're out of DB space" event in the future.

We also need to carefully consider how this will work with upgrades in the future too - if we want them to be a manual or hands-off process.

@progier389 progier389 linked a pull request Oct 10, 2023 that will close this issue
Issue 5843 - dsconf / dscreate should be able to handle lmdb parameters #5943
Merged
@progier389 progier389 mentioned this issue Oct 13, 2023
Merged
progier389 added a commit that referenced this issue Oct 13, 2023
@progier389
Issue 5843 - dsconf / dscreate should be able to handle lmdb paramete…
415eead 
…rs (#5943)

* Issue 5843 - dsconf / dscreate should be able to handle lmdb parameters

Description:

dscreate changes:
- make db_lib a standard option instead of an advanced one
- add mdb_max_size as standard option
dsconf instance backend config set changes:
- add --mdb_max_size option associated with nsslapd-mdb-max-size
- add --mdb_max_readers option associated with nsslapd-mdb_max_readers
- add --mdb_max_dbs option associated with nsslapd-mdb_max_dbs

Issue: #5843

Reviewed by: @Firstyear and @droideck ( Thanks ! )
@progier389 progier389 reopened this Oct 13, 2023
@progier389
Copy link
Contributor Author

Found a regression with dscreate create-template when creating first instance on a newly installed host
(Get a warning about not existing directory in the middle of the template ! )
Opening a new PR

@progier389
Copy link
Contributor Author

Regression fixed by PR #5950

@progier389 progier389 removed the needs triage The issue will be triaged during scrum label Jan 2, 2024
droideck added a commit to droideck/389-ds-base that referenced this issue Aug 26, 2024
@droideck
Issue 5843 - Fix size formatting in dscreate output and enhance tests
014b45d 
Description:
Fix the size formatting in `get_default_mdb_max_size` within `utils.py` to ensure `dscreate` displays the correct value in both interactive and create-template installs.
Additionally, improve and fix related LMDB configuration tests to validate the correctness of size handling. Fix typos in the test descriptions.

Relates: 389ds#5843

Reviewed by: ?
@droideck droideck mentioned this issue Aug 26, 2024
Merged
droideck added a commit that referenced this issue Aug 27, 2024
@droideck
Issue 5843 - Fix size formatting in dscreate output and enhance tests (…
98e0358 
…#6309)

Description:
Fix the size formatting in `get_default_mdb_max_size` within `utils.py` to ensure `dscreate` displays the correct value in both interactive and create-template installs.
Additionally, improve and fix related LMDB configuration tests to validate the correctness of size handling. Fix typos in the test descriptions.

Relates: #5843

Reviewed by: @progier389 (Thanks!)
droideck added a commit that referenced this issue Aug 27, 2024
@droideck
Issue 5843 - Fix size formatting in dscreate output and enhance tests (…
b3b72a3 
…#6309)

Description:
Fix the size formatting in `get_default_mdb_max_size` within `utils.py` to ensure `dscreate` displays the correct value in both interactive and create-template installs.
Additionally, improve and fix related LMDB configuration tests to validate the correctness of size handling. Fix typos in the test descriptions.

Relates: #5843

Reviewed by: @progier389 (Thanks!)
@droideck
Copy link
Member

e2495b1..98e0358 main -> origin/main
2cf519d..b3b72a3 389-ds-base-3.0 -> 389-ds-base-3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CLI CLI tools lmdb LMDB related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 5843 - dsconf / dscreate should be able to handle lmdb parameters progier389/389-ds-base
3 participants
@Firstyear @droideck @progier389