Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5843 - Fix size formatting in dscreate output and enhance tests #6309

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

droideck
Copy link
Member

Description:
Fix the size formatting in get_default_mdb_max_size within utils.py to ensure dscreate displays the correct value in both interactive and create-template installs. Additionally, improve and fix related LMDB configuration tests to validate the correctness of size handling. Fix typos in the test descriptions.

Relates: #5843

Reviewed by: ?

Description:
Fix the size formatting in `get_default_mdb_max_size` within `utils.py` to ensure `dscreate` displays the correct value in both interactive and create-template installs.
Additionally, improve and fix related LMDB configuration tests to validate the correctness of size handling. Fix typos in the test descriptions.

Relates: 389ds#5843

Reviewed by: ?
Copy link
Contributor

@progier389 progier389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droideck droideck merged commit 98e0358 into 389ds:main Aug 27, 2024
194 of 195 checks passed
droideck added a commit that referenced this pull request Aug 27, 2024
…#6309)

Description:
Fix the size formatting in `get_default_mdb_max_size` within `utils.py` to ensure `dscreate` displays the correct value in both interactive and create-template installs.
Additionally, improve and fix related LMDB configuration tests to validate the correctness of size handling. Fix typos in the test descriptions.

Relates: #5843

Reviewed by: @progier389 (Thanks!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants