Issue 5966 - CLI - Custom schema object is removed on a failed edit #5967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: When the failure happens during a custom schema edit operation in both CLI and UI (because it uses the CLI command), we first remove the old schema object and only then do we add the new one (edited). Bring the old schema object on the failed attempt. Resolves: 389ds#5966 Reviewed by: ?
mreynolds389
approved these changes
Oct 23, 2023
droideck
added a commit
that referenced
this pull request
Oct 24, 2023
…5967) Description: When the failure happens during a custom schema edit operation in both CLI and UI (because it uses the CLI command), we first remove the old schema object, and only then do we add the new one (edited). Bring the old schema object on the failed attempt. Resolves: #5966 Reviewed by: @mreynolds389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Oct 24, 2023
…5967) Description: When the failure happens during a custom schema edit operation in both CLI and UI (because it uses the CLI command), we first remove the old schema object, and only then do we add the new one (edited). Bring the old schema object on the failed attempt. Resolves: #5966 Reviewed by: @mreynolds389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Oct 24, 2023
…5967) Description: When the failure happens during a custom schema edit operation in both CLI and UI (because it uses the CLI command), we first remove the old schema object, and only then do we add the new one (edited). Bring the old schema object on the failed attempt. Resolves: #5966 Reviewed by: @mreynolds389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Oct 24, 2023
…5967) Description: When the failure happens during a custom schema edit operation in both CLI and UI (because it uses the CLI command), we first remove the old schema object, and only then do we add the new one (edited). Bring the old schema object on the failed attempt. Resolves: #5966 Reviewed by: @mreynolds389 (Thanks!)
droideck
added a commit
that referenced
this pull request
Oct 24, 2023
…5967) Description: When the failure happens during a custom schema edit operation in both CLI and UI (because it uses the CLI command), we first remove the old schema object, and only then do we add the new one (edited). Bring the old schema object on the failed attempt. Resolves: #5966 Reviewed by: @mreynolds389 (Thanks!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: When the failure happens during a custom schema edit operation in both CLI and UI (because it uses the CLI command), we first remove the old schema object and only then do we add the new one (edited).
Bring the old schema object on the failed attempt.
Resolves: #5966
Reviewed by: ?