Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 5941 - Switch default backend to lmdb and change version to 3.0 #6013

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Issue 5941 - Switch default backend to lmdb and change version to 3.0 #6013

merged 1 commit into from
Jan 19, 2024

Conversation

progier389
Copy link
Contributor

@progier389 progier389 commented Dec 18, 2023 •
edited
Loading

Changes:
[1] use lmdb by default
[2] Change version number to 3.0.0

Issue: #5941

Reviewed by: @droideck, @tbordaz (Thanks!)

@progier389
Copy link
Contributor Author

FYI: I plan to merge that one next year to

  • avoid doing a major change just before Christmas break! -;)
  • start the nightly freeipa tests on Fedora 40 as soon as possible.

@progier389 progier389 changed the title Issue 5941 - Switch default backend to lmdb and bump version to 3.0 Issue 5941 - Switch default backend to lmdb and change version to 3.0 Jan 18, 2024
droideck
droideck approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@droideck droideck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is straightforward and looks good to me.
You have my ack if the CI passes after #6035 rebase! (except the usual web test failures)

@progier389
Copy link
Contributor Author

Rebased to main

@progier389
Copy link
Contributor Author

Waiting for the CI tests result - These days only webui should fails (and the random failures due to dnf race condition)

tbordaz
tbordaz approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@tbordaz tbordaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. True pleasure to click 'Approve' on this PR ;)

@progier389 progier389 merged commit 7082c82 into 389ds:main Jan 19, 2024
193 of 195 checks passed
@progier389 progier389 deleted the i5941 branch March 28, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droideck droideck droideck approved these changes

@tbordaz tbordaz tbordaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@progier389 @tbordaz @droideck