str2entry_dupcheck not all errors are logged #2182 #6023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droideck
requested changes
Jan 8, 2024
kimettog
force-pushed
the
gk_str2_entrydupcheck
branch
3 times, most recently
from
d991c65 to
e978a41
Compare
droideck
requested changes
Jan 12, 2024
There was a problem hiding this comment.
Hmm, I've tried to import perfectly fine LDIF, and it gave me a lot of false warnings...
Steps to reproduce:
- Install an instance with sample entries
- Export a suffix from UI (Database - Suffixes - Suffix Tasks - Export Suffix) - Name the ldif.
- Import the suffix from UI (Database - Suffixes - Suffix Tasks - Initialise Suffix) - Choose the ldif.
- Check the logs for WARNs.
Could you please add another test that will check for clean export-import?
And we need to ensure that the logs are not filled with false warnings.
kimettog
force-pushed
the
gk_str2_entrydupcheck
branch
from
e978a41 to
75c9cc9
Compare
kimettog
force-pushed
the
gk_str2_entrydupcheck
branch
3 times, most recently
from
f9bc320 to
1589797
Compare
kimettog
force-pushed
the
gk_str2_entrydupcheck
branch
6 times, most recently
from
2f6ed7f to
1f10a70
Compare
kimettog
force-pushed
the
gk_str2_entrydupcheck
branch
3 times, most recently
from
e7a2fc3 to
565df36
Compare
kimettog
force-pushed
the
gk_str2_entrydupcheck
branch
from
565df36 to
7a8af03
Compare
kimettog
force-pushed
the
gk_str2_entrydupcheck
branch
3 times, most recently
from
ad8773e to
59e78e9
Compare
kimettog
force-pushed
the
gk_str2_entrydupcheck
branch
from
59e78e9 to
fdeed50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue ##### -
Bug Description:
str2entry_dupcheck not all errors are logged #2182
Fix Description:
A number of error cases in str2entry_dupcheck are only logged at LOG_TRACE, when they should be logged at an error level (WARNING, ERR). This can cause silent failures of imports.
relates: #2182
Author: Gilbert Kimetto
Reviewed by: Simon Pichugi