Flag that replica_id is int not str (Fixes #6033) #6034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Elwell, could you please update the commit message according to https://www.port389.org/docs/389ds/contributing.html? I.e. bug description and fix description, even though it's trivial. It would greatly help, thanks! |
Bug Description: dscreate create-template claims replica_id is (str) but it should be an int Fix Description: Change self._type['replica_id'] = str to self._type['replica_id'] = int Fixes: #6033 Author: Andrew Elwell <[email protected]> Reviewed by: @vashirov
vashirov
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.