Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6041 - dscreate ds-root - accepts relative path #6042

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

jchapma
Copy link
Contributor

@jchapma jchapma commented Jan 19, 2024

Bug Description: When dscreate ds-root is invoked with a relative path to root_dir, the relative path is written to defaults.inf, causing instance creation failure.

Fix Description: Use abs path when writing root_dir to defaults.inf

Fixes: #6041

Reviewed by:

Bug Description: When dscreate ds-root is invoked with a relative path to
root_dir, the relative path is written to defaults.inf, causing instance
creation failure.

Fix Description: Use abs path when writing root_dir to defaults.inf

Fixes: 389ds#6041

Reviewed by:
Copy link
Contributor

@progier389 progier389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jchapma jchapma merged commit 7a158c7 into 389ds:main Jan 22, 2024
185 of 195 checks passed
jchapma added a commit that referenced this pull request Jan 22, 2024
Bug Description: When dscreate ds-root is invoked with a relative path to
root_dir, the relative path is written to defaults.inf, causing instance
creation failure.

Fix Description: Use abs path when writing root_dir to defaults.inf

Fixes: #6041

Reviewed by: @progier389, @droideck (Thank you)
jchapma added a commit that referenced this pull request Jan 22, 2024
Bug Description: When dscreate ds-root is invoked with a relative path to
root_dir, the relative path is written to defaults.inf, causing instance
creation failure.

Fix Description: Use abs path when writing root_dir to defaults.inf

Fixes: #6041

Reviewed by: @progier389, @droideck (Thank you)
jchapma added a commit that referenced this pull request Jan 22, 2024
Bug Description: When dscreate ds-root is invoked with a relative path to
root_dir, the relative path is written to defaults.inf, causing instance
creation failure.

Fix Description: Use abs path when writing root_dir to defaults.inf

Fixes: #6041

Reviewed by: @progier389, @droideck (Thank you)
jchapma added a commit that referenced this pull request Jan 22, 2024
Bug Description: When dscreate ds-root is invoked with a relative path to
root_dir, the relative path is written to defaults.inf, causing instance
creation failure.

Fix Description: Use abs path when writing root_dir to defaults.inf

Fixes: #6041

Reviewed by: @progier389, @droideck (Thank you)
jchapma added a commit that referenced this pull request Jan 22, 2024
Bug Description: When dscreate ds-root is invoked with a relative path to
root_dir, the relative path is written to defaults.inf, causing instance
creation failure.

Fix Description: Use abs path when writing root_dir to defaults.inf

Fixes: #6041

Reviewed by: @progier389, @droideck (Thank you)
jchapma added a commit that referenced this pull request Jan 22, 2024
Bug Description: When dscreate ds-root is invoked with a relative path to
root_dir, the relative path is written to defaults.inf, causing instance
creation failure.

Fix Description: Use abs path when writing root_dir to defaults.inf

Fixes: #6041

Reviewed by: @progier389, @droideck (Thank you)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dscreate ds-root - accepts relative path
3 participants