-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 6041 - dscreate ds-root - accepts relative path #6042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Description: When dscreate ds-root is invoked with a relative path to root_dir, the relative path is written to defaults.inf, causing instance creation failure. Fix Description: Use abs path when writing root_dir to defaults.inf Fixes: 389ds#6041 Reviewed by:
progier389
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
droideck
approved these changes
Jan 19, 2024
jchapma
added a commit
that referenced
this pull request
Jan 22, 2024
Bug Description: When dscreate ds-root is invoked with a relative path to root_dir, the relative path is written to defaults.inf, causing instance creation failure. Fix Description: Use abs path when writing root_dir to defaults.inf Fixes: #6041 Reviewed by: @progier389, @droideck (Thank you)
jchapma
added a commit
that referenced
this pull request
Jan 22, 2024
Bug Description: When dscreate ds-root is invoked with a relative path to root_dir, the relative path is written to defaults.inf, causing instance creation failure. Fix Description: Use abs path when writing root_dir to defaults.inf Fixes: #6041 Reviewed by: @progier389, @droideck (Thank you)
jchapma
added a commit
that referenced
this pull request
Jan 22, 2024
Bug Description: When dscreate ds-root is invoked with a relative path to root_dir, the relative path is written to defaults.inf, causing instance creation failure. Fix Description: Use abs path when writing root_dir to defaults.inf Fixes: #6041 Reviewed by: @progier389, @droideck (Thank you)
jchapma
added a commit
that referenced
this pull request
Jan 22, 2024
Bug Description: When dscreate ds-root is invoked with a relative path to root_dir, the relative path is written to defaults.inf, causing instance creation failure. Fix Description: Use abs path when writing root_dir to defaults.inf Fixes: #6041 Reviewed by: @progier389, @droideck (Thank you)
jchapma
added a commit
that referenced
this pull request
Jan 22, 2024
Bug Description: When dscreate ds-root is invoked with a relative path to root_dir, the relative path is written to defaults.inf, causing instance creation failure. Fix Description: Use abs path when writing root_dir to defaults.inf Fixes: #6041 Reviewed by: @progier389, @droideck (Thank you)
jchapma
added a commit
that referenced
this pull request
Jan 22, 2024
Bug Description: When dscreate ds-root is invoked with a relative path to root_dir, the relative path is written to defaults.inf, causing instance creation failure. Fix Description: Use abs path when writing root_dir to defaults.inf Fixes: #6041 Reviewed by: @progier389, @droideck (Thank you)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description: When dscreate ds-root is invoked with a relative path to root_dir, the relative path is written to defaults.inf, causing instance creation failure.
Fix Description: Use abs path when writing root_dir to defaults.inf
Fixes: #6041
Reviewed by: