Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6345 - Ensure all slapi_log_err calls end format strings with newline character \n #6346

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

droideck
Copy link
Member

Description: In the codebase, there are instances where calls to slapi_log_err are missing a newline character \n at the end of the format string. This omission can lead to log messages being concatenated in the logs, affecting readability and potentially hindering log parsing and analysis tools. Fix the typos.

Fixes: #6345

Reviewed by: ?

…ewline character \n

Description: In the codebase, there are instances where calls to slapi_log_err are missing a newline character \n at the end of the format string. This omission can lead to log messages being concatenated in the logs, affecting readability and potentially hindering log parsing and analysis tools.
Fix the typos.

Fixes: 389ds#6345

Reviewed by: ?
Copy link
Contributor

@progier389 progier389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tbordaz tbordaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good. Just one question

ldap/servers/plugins/whoami/whoami.c Outdated Show resolved Hide resolved
@droideck droideck merged commit 8fbc7d8 into 389ds:main Sep 28, 2024
197 checks passed
droideck added a commit that referenced this pull request Sep 28, 2024
…ewline character \n (#6346)

Description: In the codebase, there are instances where calls to slapi_log_err
are missing a newline character \n at the end of the format string.
This omission can lead to log messages being concatenated in the logs,
affecting readability and potentially hindering log parsing and analysis tools.
Fix the typos.

Fixes: #6345

Reviewed by: @progier389, @tbordaz (Thanks!)
droideck added a commit that referenced this pull request Sep 28, 2024
…ewline character \n (#6346)

Description: In the codebase, there are instances where calls to slapi_log_err
are missing a newline character \n at the end of the format string.
This omission can lead to log messages being concatenated in the logs,
affecting readability and potentially hindering log parsing and analysis tools.
Fix the typos.

Fixes: #6345

Reviewed by: @progier389, @tbordaz (Thanks!)
droideck added a commit that referenced this pull request Sep 28, 2024
…ewline character \n (#6346)

Description: In the codebase, there are instances where calls to slapi_log_err
are missing a newline character \n at the end of the format string.
This omission can lead to log messages being concatenated in the logs,
affecting readability and potentially hindering log parsing and analysis tools.
Fix the typos.

Fixes: #6345

Reviewed by: @progier389, @tbordaz (Thanks!)
droideck added a commit that referenced this pull request Sep 28, 2024
…ewline character \n (#6346)

Description: In the codebase, there are instances where calls to slapi_log_err
are missing a newline character \n at the end of the format string.
This omission can lead to log messages being concatenated in the logs,
affecting readability and potentially hindering log parsing and analysis tools.
Fix the typos.

Fixes: #6345

Reviewed by: @progier389, @tbordaz (Thanks!)
droideck added a commit that referenced this pull request Sep 28, 2024
…ewline character \n (#6346)

Description: In the codebase, there are instances where calls to slapi_log_err
are missing a newline character \n at the end of the format string.
This omission can lead to log messages being concatenated in the logs,
affecting readability and potentially hindering log parsing and analysis tools.
Fix the typos.

Fixes: #6345

Reviewed by: @progier389, @tbordaz (Thanks!)
droideck added a commit that referenced this pull request Sep 28, 2024
…ewline character \n (#6346)

Description: In the codebase, there are instances where calls to slapi_log_err
are missing a newline character \n at the end of the format string.
This omission can lead to log messages being concatenated in the logs,
affecting readability and potentially hindering log parsing and analysis tools.
Fix the typos.

Fixes: #6345

Reviewed by: @progier389, @tbordaz (Thanks!)
droideck added a commit that referenced this pull request Sep 28, 2024
…ewline character \n (#6346)

Description: In the codebase, there are instances where calls to slapi_log_err
are missing a newline character \n at the end of the format string.
This omission can lead to log messages being concatenated in the logs,
affecting readability and potentially hindering log parsing and analysis tools.
Fix the typos.

Fixes: #6345

Reviewed by: @progier389, @tbordaz (Thanks!)
droideck added a commit that referenced this pull request Sep 28, 2024
…ewline character \n (#6346)

Description: In the codebase, there are instances where calls to slapi_log_err
are missing a newline character \n at the end of the format string.
This omission can lead to log messages being concatenated in the logs,
affecting readability and potentially hindering log parsing and analysis tools.
Fix the typos.

Fixes: #6345

Reviewed by: @progier389, @tbordaz (Thanks!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure all slapi_log_err calls end format strings with newline character \n
3 participants