Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6224 - Remove test_referral_subsuffix from ds_logs_test.py #6457

Conversation

mmatsuya
Copy link
Collaborator

@mmatsuya mmatsuya commented Dec 19, 2024

Bug Description:

test_referral_subsuffix test was removed from main branch and some other ones for higher versions. But, it was not removed from 389-ds-base-1.4.3 and 389-ds-base-2.1. The test doesn't work anymore with the fix for Issue 6224, because the added new control limited one backend for internal search. The test should be removed.

Fix Description:

remove the test from ds_logs_test.py

relates: #6224

Reviewed by: @tbordaz, @droideck (Thanks!)

Bug Description:

test_referral_subsuffix test was removed from main branch and some other
ones for higher versions. But, it was not removed from 389-ds-base-1.4.3
and 389-ds-base-2.1. The test doesn't work anymore with the fix for
Issue 6224, because the added new control limited one backend for internal
search. The test should be removed.

Fix Description:

remove the test from ds_logs_test.py

relates: 389ds#6224
Copy link
Contributor

@tbordaz tbordaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatsuya
Copy link
Collaborator Author

I don't have a permission to merge by myself. Please feel free to merge it.

@progier389
Copy link
Contributor

Bug Description:

test_referral_subsuffix test was removed from main branch and some other ones for higher versions. But, it was not removed from 389-ds-base-1.4.3 and 389-ds-base-2.1. The test doesn't work anymore with the fix for Issue 6224, because the added new control limited one backend for internal search. The test should be removed.

Fix Description:

remove the test from ds_logs_test.py

relates: #6224

Reviewed by: @tbordaz, @droideck (Thanks!)

@progier389 progier389 merged commit 98ae637 into 389ds:389-ds-base-2.1 Jan 16, 2025
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants