Issue 6470 - Some replication status data are reset upon a restart #6471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug description: The replication agreement contains operational attributes related to the total init: nsds5replicaLastInitStart, nsds5replicaLastInitEnd, nsds5replicaLastInitStatus. Those attributes are reset at restart Fix description: When reading the replication agreement from config (agmt_new_from_entry) restore the attributes into the in-memory RA. Updates the RA config entry from the in-memory RA during shutdown/cleanallruv/enable_ra fixes: 389ds#6470 Reviewed by:
droideck
approved these changes
Jan 9, 2025
| assert initEnd_2 != initEnd_1 | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Another new line we can live without:)
| break | ||
| assert supplier_consumer | ||
|
|
||
|
|
droideck
reviewed
Jan 9, 2025
| } | ||
| if (ra->last_init_status[0] != '\0') { | ||
| nb_mods++; | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
| if (nb_mods == 0) { | |
| PR_Unlock(ra->lock); | |
| return; | |
| } |
I think it's better to return here if there are no mods.
It feels a bit strange to check it at the end of the function and then call slapi_mod_done(*); even though no mods were done...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description:
The replication agreement contains operational attributes
related to the total init: nsds5replicaLastInitStart,
nsds5replicaLastInitEnd, nsds5replicaLastInitStatus.
Those attributes are reset at restart
Fix description:
When reading the replication agreement from config
(agmt_new_from_entry) restore the attributes into
the in-memory RA.
Updates the RA config entry from the in-memory RA
during shutdown/cleanallruv/enable_ra
fixes: #6470
Reviewed by: