Issue 6483 - CI - fix filter_test - test_match_large_valueset #6484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droideck
approved these changes
Jan 9, 2025
Comment on lines
376
to
377
| except Exception as e: | ||
| raise e |
There was a problem hiding this comment.
I think this part is completely redundant...
It basically just catches and immediately re-raises the same exception without performing any additional actions.
Even though it's better than bare except: raise - still, I'd just remove it:)
There was a problem hiding this comment.
I was just fixing lint errors, I can take it out.
Description: Fix filter_test::test_match_large_valueset The suffix and parent parameters to dbgen_users was switched Relates: 389ds#6483 Reviewed by: spichugi(Thanks!)
mreynolds389
force-pushed
the
fix_dbgen
branch
from
97ce44e to
1cc6b66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix filter_test::test_match_large_valueset
The suffix parameter to dbgen_users was using the wrong DN (user ou versus DEFAULT suffix)
Relates: #6483