Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 6490 - Adjust rust pwchan error severity level #6491

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Issue 6490 - Adjust rust pwchan error severity level #6491

merged 1 commit into from
Jan 11, 2025

Conversation

mreynolds389
Copy link
Contributor

Description:

We log an info message about the pbkdf2 iterations, but the severity level is ERR, when it should be INFO.

Relates: #6490

@droideck
Copy link
Member

droideck commented Jan 9, 2025

Good catch!
It actually needs more work, I think... I remember I wanted to move the message so it's displayed only on the start-up, but then the new defaults issue consumed me.

As of now, it prints the message each time user sets password:

[09/Jan/2025:15:07:48.124037281 -0500] - INFO - plugins/pwdchan/src/lib.rs:367 - get_pbkdf2_rounds -> PBKDF2 rounds for SHA512 is 100000
[09/Jan/2025:15:07:48.232636925 -0500] - INFO - plugins/pwdchan/src/lib.rs:367 - get_pbkdf2_rounds -> PBKDF2 rounds for SHA512 is 100000
[09/Jan/2025:15:07:48.342133649 -0500] - INFO - plugins/pwdchan/src/lib.rs:367 - get_pbkdf2_rounds -> PBKDF2 rounds for SHA512 is 100000
[09/Jan/2025:15:07:48.472427555 -0500] - INFO - plugins/pwdchan/src/lib.rs:367 - get_pbkdf2_rounds -> PBKDF2 rounds for SHA512 is 100000
[09/Jan/2025:15:07:48.575975447 -0500] - INFO - plugins/pwdchan/src/lib.rs:367 - get_pbkdf2_rounds -> PBKDF2 rounds for SHA512 is 100000

Also, I don't like plugins/pwdchan/src/lib.rs:367 part and I think it needs to be cleaned.

I'll check the code later today, I think it's urgent enough to resolve it as soon as possible.

@mreynolds389
Copy link
Contributor Author

Good catch! It actually needs more work, I think... I remember I wanted to move the message so it's displayed only on the start-up, but then the new defaults issue consumed me.
I'll check the code later today, I think it's urgent enough to resolve it as soon as possible.

I'll look into it. I haven't played around with any rust code yet...

@mreynolds389
Copy link
Contributor Author

Good catch! It actually needs more work, I think... I remember I wanted to move the message so it's displayed only on the start-up, but then the new defaults issue consumed me.
I'll check the code later today, I think it's urgent enough to resolve it as soon as possible.

I'll look into it. I haven't played around with any rust code yet...

As discussed offline, I just removed the logging call for now.

droideck
droideck approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@droideck
Copy link
Member

Oh, and also, the commit subject needs to be changed.

@mreynolds389
Issue 6490 - Remove the rust error log message for pbkdf2 rounds
5aec7f0 
Description:

We log an info message about the pbkdf2 iterations, but the severity level is
ERR. Just removing the logging for now, and it will added back later at
a more appropriate location.

Relates: 389ds#6490

Reviewed by: spichugi(Thanks!)
@mreynolds389 mreynolds389 merged commit f2abeb0 into 389ds:main Jan 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droideck droideck droideck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mreynolds389 @droideck