Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display a generic error in case of action failure to the end-user #5105

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Display a generic error in case of action failure to the end-user #5105

merged 1 commit into from
Dec 11, 2024

Conversation

Gustry
Copy link
Member

@Gustry Gustry commented Dec 10, 2024

When not connected on the instance @mdouchin

Does the action writer is using raise to show error to the end user ?

image

@Gustry Gustry requested a review from mdouchin December 10, 2024 15:06
@github-actions github-actions bot added this to the 3.10.0 milestone Dec 10, 2024
@Gustry Gustry added the run end2end If the PR must run end2end tests or not label Dec 10, 2024
mdouchin
mdouchin approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@mdouchin mdouchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Gustry
Copy link
Member Author

Gustry commented Dec 11, 2024

More work to do later :

  • Use a translated string
  • Always report to the GIS technician in case of a failure before on an action

Linked somehow to #3084 and #5066

@Gustry Gustry merged commit 2f43c2f into 3liz:master Dec 11, 2024
19 checks passed
@Gustry Gustry deleted the action-error branch December 11, 2024 14:27
This was referenced Dec 11, 2024
Merged
Merged
Merged
@Gustry Gustry mentioned this pull request Dec 11, 2024
Merged
nboisteault pushed a commit to nboisteault/lizmap-web-client that referenced this pull request Dec 12, 2024
@Gustry
Merge pull request 3liz#5105 from Gustry/action-error
b4bec8d 
Display a generic error in case of action failure to the end-user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdouchin mdouchin mdouchin approved these changes

@rldhont rldhont rldhont approved these changes

Assignees
No one assigned
Labels
action backport release_3_7 backport release_3_8 backport release_3_9 bug run end2end If the PR must run end2end tests or not
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Gustry @rldhont @mdouchin