Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused backend client #1490

Merged
merged 2 commits into from
Sep 25, 2024
Merged

remove unused backend client #1490

merged 2 commits into from
Sep 25, 2024

Conversation

eguzki
Copy link
Member

@eguzki eguzki commented Aug 23, 2024

No description provided.

@eguzki
Copy link
Member Author

eguzki commented Aug 26, 2024

Broken link issue fixed in #1492

@eguzki
Copy link
Member Author

eguzki commented Aug 26, 2024 •
edited
Loading

@tkan145 is this ____http_call location being used? maybe for backend?

tests are passing 🤷

@tkan145
Copy link
Contributor

tkan145 commented Aug 26, 2024

It's being used here. However, I don't think we are currently using ngx backend, default is resty backend.

@eguzki eguzki force-pushed the removed-unused-config branch from 91f8b66 to 0292b0e Compare August 26, 2024 13:00
@eguzki eguzki changed the title remove unused location ___http_call remove unused backend client Aug 26, 2024
@eguzki eguzki force-pushed the removed-unused-config branch from 0b08ebc to 648c888 Compare September 11, 2024 07:21
@eguzki eguzki marked this pull request as ready for review September 11, 2024 07:22
@eguzki eguzki requested a review from a team as a code owner September 11, 2024 07:22
tkan145
tkan145 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@tkan145 tkan145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eguzki eguzki merged commit 57228c8 into master Sep 25, 2024
15 checks passed
@eguzki eguzki deleted the removed-unused-config branch September 25, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkan145 tkan145 tkan145 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eguzki @tkan145