Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests and invalid link #1524

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Fix flaky tests and invalid link #1524

merged 3 commits into from
Jan 22, 2025

Conversation

tkan145
Copy link
Contributor

@tkan145 tkan145 commented Jan 21, 2025

What

  • Fix flaky tests
  • Fix invalid link

@tkan145 tkan145 force-pushed the flaky-tests branch 5 times, most recently from 06ad5fb to bfb387d Compare January 22, 2025 13:18
@tkan145 tkan145 changed the title Flaky tests Fix flaky tests and invalid link Jan 22, 2025
@tkan145 tkan145 marked this pull request as ready for review January 22, 2025 13:36
@tkan145 tkan145 requested a review from a team as a code owner January 22, 2025 13:36
By default we run the prove task based on the number of available CPU cores.
The nprocs test will return the number of available CPU cores in the docker
executor VM, however the medium resource class only has access to
3 CPUs.

So the prove task will always spawn more workers than the number of available
CPU cores, which then causes the CPU to max out during the test and cause
random errors.
@tkan145 tkan145 merged commit 102e02d into 3scale:master Jan 22, 2025
14 checks passed
@tkan145 tkan145 deleted the flaky-tests branch January 22, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants