Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Correct the dependencies path #1527

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

tkan145
Copy link
Contributor

@tkan145 tkan145 commented Jan 21, 2025

What

Correct the wrong dependencies path

Verification steps

  • Fetch submodules
git submodule update --recursive 
  • Edit Makefile as below
diff --git a/Makefile b/Makefile
index b77767fe..938b3a20 100644
--- a/Makefile
+++ b/Makefile
@@ -150,7 +150,7 @@ prove-docker: ## Test nginx inside docker
 
 runtime-image: IMAGE_NAME ?= apicast-runtime-image:latest
 runtime-image: ## Build runtime image
-       $(DOCKER) build -t $(IMAGE_NAME) $(PROJECT_PATH)
+       $(DOCKER) build -t $(IMAGE_NAME) -f Containerfile $(PROJECT_PATH)
 
 push: ## Push image to the registry
        docker tag $(IMAGE_NAME) $(REGISTRY)/$(IMAGE_NAME)
  • Build runtime-image
make runtime-image
  • It should produce an image without error

@tkan145 tkan145 requested a review from a team as a code owner January 21, 2025 23:45
@tkan145 tkan145 requested a review from gsaslis January 23, 2025 00:13
Copy link
Member

@gsaslis gsaslis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me (LGTM)

@tkan145 tkan145 merged commit 11b264a into 3scale:master Jan 23, 2025
14 checks passed
@tkan145 tkan145 deleted the dependencies-path branch January 23, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants