Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/alarm cate #194 #195 #210

Merged
merged 4 commits into from
Mar 12, 2022
Merged

Feature/alarm cate #194 #195 #210

merged 4 commits into from
Mar 12, 2022

Conversation

GulSam00
Copy link
Member

@GulSam00 GulSam00 commented Mar 8, 2022

#194 알람 페이지

  • 알람 클릭 시 해당 글로 리다이렉팅 되게끔 구현했습니다.

#195 카테고리 스위칭 + 무한 스크롤

  • 카테고리를 스위칭 할 경우 기존 글을 전부 초기화하고 새로 받아올 수 있게끔 useEffect를 조정했습니다.
  • state로 관리하던 page, hasNextPage를 let으로 관리하도록 변경했습니다.

}
setCurCate(getCategoryByUrl(loca));
}, []);
setArticles([]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

카테고리 스위칭과 무한스크롤 충돌을 어떻게 수정하셨는지 정말 궁금했는데 curCate 상태값 삭제하시고 게시물을 0개로 초기화한뒤 무한스크롤을 통해서 게시물을 받아오는 방식으로 바꾸셨군요... 좋습니다....

Copy link
Member

@chichoon chichoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ~.~
이제 에러 메시지 출력이 되지 않고 바로 에러창으로 넘어가게 통일되어가는군요

Copy link
Contributor

@hyongti hyongti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Copy link
Member

@PIut0 PIut0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PIut0 PIut0 merged commit fd7371e into dev Mar 12, 2022
@PIut0 PIut0 deleted the feature/AlarmCate branch March 12, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants