Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS Review - fdmr::retrieve_tutorial_data should not modify the home directory #326

Closed
wcjochem opened this issue Aug 29, 2024 · 0 comments · Fixed by #330
Closed

JOSS Review - fdmr::retrieve_tutorial_data should not modify the home directory #326

wcjochem opened this issue Aug 29, 2024 · 0 comments · Fixed by #330
Assignees
Labels
JOSS Joss paper issues

Comments

@wcjochem
Copy link

Is your feature request related to a problem? Please describe.
fdmr::retrieve_tutorial_data() should not modify my home directory and I should have an option to choose where data should be downloaded.

Describe the solution you'd like
I think there should be an argument to the function to specify the download location, and the default download location should be the temporary directory.

Describe alternatives you've considered

Additional context
If you have aspirations for this package to go to CRAN then it cannot write anywhere except for R's temporary directory by default.

openjournals/joss-reviews#7047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JOSS Joss paper issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants