Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated paper.md #335

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Updated paper.md #335

merged 1 commit into from
Oct 23, 2024

Conversation

rwestaway
Copy link
Contributor

@rwestaway rwestaway commented Oct 22, 2024

  • Summary of changes (Bug fix, feature, docs update, ...)

  • Please check if the PR fulfills these requirements

  • Closes #xxxx (replace xxxx with the GitHub issue number)
  • Tests added and passed
  • All code checks passing - styler run over code
  • Vignettes updated/added
  • Added an entry in the latest CHANGELOG.md file if fixing a bug or adding a new feature
  • Any new libraries added to DESCRIPTION

Revised paper with additional 'state of field' text suggested by JA
@mnky9800n mnky9800n self-assigned this Oct 23, 2024
@mnky9800n mnky9800n changed the base branch from devel to JOSS October 23, 2024 08:59
@mnky9800n
Copy link
Contributor

im pretty sure this is supposed to be merged with JOSS branch and not devel but @rwestaway if you think differently let me know.

@rwestaway
Copy link
Contributor Author

I have no idea! I simply edited the original paper.md file. I think it needs to be in that location for the 'convert to pdf' function to work but I don't really know.....

@mnky9800n
Copy link
Contributor

State of the field
Additional text added to manuscript. #329

Functionality documentation
added. #332

error in model_viewer description
fixed. #331

fdmr::retrieve_tutorial_data should not modify the home directory
fixed #326

Notebooks depend on "INLA" package
fixed #325 #334

@mnky9800n mnky9800n merged commit 69e97db into 4DModeller:JOSS Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants