-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new geophysics tutorial draft and MT dataset added #257
Conversation
@gareth-j this fails on package down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XueqingYin @gareth-j there needs to be something changed wtih the mesh so that the rmarkdown compiles and package down doesnt fall over.
x.mat[, co] <- INLA::inla.qsample(n = 1, Q) | ||
} | ||
|
||
A <- INLA::inla.spde.make.A(mesh = mesh, loc = locations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the package down is failing because of this line, but i dont understand what is wrong with the mesh/locations @gareth-j do you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks @4minakov
Summary of changes (Bug fix, feature, docs update, ...)
Please check if the PR fulfills these requirements
styler
run over codeCHANGELOG.md
file if fixing a bug or adding a new featureDESCRIPTION