Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new geophysics tutorial draft and MT dataset added #257

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

4minakov
Copy link

@4minakov 4minakov commented Nov 5, 2023

  • Summary of changes (Bug fix, feature, docs update, ...)

  • Please check if the PR fulfills these requirements

  • Closes #xxxx (replace xxxx with the GitHub issue number)
  • Tests added and passed
  • All code checks passing - styler run over code
  • Vignettes updated/added
  • Added an entry in the latest CHANGELOG.md file if fixing a bug or adding a new feature
  • Any new libraries added to DESCRIPTION

@mnky9800n
Copy link
Contributor

@gareth-j this fails on package down.

Copy link
Contributor

@XueqingYin XueqingYin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@mnky9800n mnky9800n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XueqingYin @gareth-j there needs to be something changed wtih the mesh so that the rmarkdown compiles and package down doesnt fall over.

x.mat[, co] <- INLA::inla.qsample(n = 1, Q)
}

A <- INLA::inla.spde.make.A(mesh = mesh, loc = locations)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the package down is failing because of this line, but i dont understand what is wrong with the mesh/locations @gareth-j do you know?

@gareth-j gareth-j changed the base branch from main to devel November 17, 2023 11:20
@gareth-j gareth-j added documentation Improvements or additions to documentation hackathon-23 labels Nov 17, 2023
@gareth-j gareth-j changed the base branch from devel to geophysicsTut November 17, 2023 15:11
Copy link
Contributor

@gareth-j gareth-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @4minakov

@gareth-j gareth-j merged commit f2b2aa1 into 4DModeller:geophysicsTut Nov 17, 2023
2 of 3 checks passed
@gareth-j gareth-j mentioned this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation hackathon-23
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants