Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snow #259

Merged
merged 17 commits into from
Nov 20, 2023
Merged

Snow #259

merged 17 commits into from
Nov 20, 2023

Conversation

desireetreichler
Copy link
Contributor

  • New snow tutorial. Contains: snow data, first steps, description of development needed to work this into a full tutorial

  • Please check if the PR fulfills these requirements

None of the following has been done as this is in draft/development stage.

  • Closes #xxxx (replace xxxx with the GitHub issue number)
  • Tests added and passed
  • All code checks passing - styler run over code
  • Vignettes updated/added
  • Added an entry in the latest CHANGELOG.md file if fixing a bug or adding a new feature
  • Any new libraries added to DESCRIPTION

@desireetreichler desireetreichler marked this pull request as ready for review November 17, 2023 11:11
@gareth-j gareth-j added documentation Improvements or additions to documentation hackathon-23 labels Nov 17, 2023
@mnky9800n mnky9800n requested a review from gareth-j November 17, 2023 11:53
@gareth-j
Copy link
Contributor

Thanks for this @desireetreichler!

@gareth-j gareth-j changed the base branch from main to snowTutorial November 17, 2023 16:27
Copy link
Contributor

@gareth-j gareth-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @desireetreichler and team! We've opened some issues for the TODO sections and will let you know once we've implemented the changes.

@gareth-j gareth-j merged commit 05f09e6 into 4DModeller:snowTutorial Nov 20, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation hackathon-23
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants