Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new NSE table #1350

Merged
merged 38 commits into from
Nov 9, 2023
Merged

new NSE table #1350

merged 38 commits into from
Nov 9, 2023

Conversation

zingale
Copy link
Member

@zingale zingale commented Oct 12, 2023

A new NSE table for aprox19 created with pynucastro replaces the original NSE table.
This has mostly the same range of validity, but has finer dlogT spacing and also tabulates
dAbar/dt, d<B/A>/dt, and e_nu.

This also contains a notebook that can be used to inspect the true NSE result from pynucastro at an arbitrary thermodynamic point.

Finally, we include the python script that generates the table.

@zingale zingale changed the base branch from main to development October 30, 2023 17:15
@zingale zingale changed the title [WIP] new NSE table new NSE table Nov 4, 2023
@zingale
Copy link
Member Author

zingale commented Nov 6, 2023

here's the test suite run that uses the table:
http://groot.astro.sunysb.edu/Microphysics/test-suite/gfortran/2023-11-06-001/test_react_C-aprox19-NSE-VODE.html

there are diffs, as should be expected.

This requires compiling with

```
USE_TABULAR_NSE=TRUE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean USE_NSE_TABLE here.

following should be copied into the on-grid network's subdirectory
(e.g. `networks/aprox19/`):

* `nse.tbl` : this is the table itself. *It should really be renamed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we got rid of nse.tbl, so maybe delete the first sentence?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, this is the output of the script and then it is suggested that it be renamed. My goal is to make this script eventually support any net.

AMREX_GPU_MANAGED amrex::Array1D<amrex::Real, 1, npts> abartab;
AMREX_GPU_MANAGED amrex::Array1D<amrex::Real, 1, npts> ebtab;
AMREX_GPU_MANAGED amrex::Array1D<amrex::Real, 1, npts> wratetab;
AMREX_GPU_MANAGED amrex::Array1D<amrex::Real, 1, npts> abartab;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different indent

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

T_values=Ts,
Ye_values=yes,
comp_reduction_func=get_aprox19_comp,
verbose=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this script is specifically for aprox19, is it better to just move it there and change outfile=nse_aprox19.tbl ?. Then I guess README also needs to change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my goal is to eventually make it support any net. I will make it clear in the README how to switch it to a different net.

@zingale zingale merged commit 6ceeb5d into AMReX-Astro:development Nov 9, 2023
24 checks passed
@zingale zingale deleted the pynucastro_nse_table branch November 9, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants