-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new NSE table #1350
new NSE table #1350
Conversation
…s into pynucastro_nse_table
here's the test suite run that uses the table: there are diffs, as should be expected. |
nse_tabular/README.md
Outdated
This requires compiling with | ||
|
||
``` | ||
USE_TABULAR_NSE=TRUE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you mean USE_NSE_TABLE
here.
following should be copied into the on-grid network's subdirectory | ||
(e.g. `networks/aprox19/`): | ||
|
||
* `nse.tbl` : this is the table itself. *It should really be renamed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we got rid of nse.tbl
, so maybe delete the first sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, this is the output of the script and then it is suggested that it be renamed. My goal is to make this script eventually support any net.
AMREX_GPU_MANAGED amrex::Array1D<amrex::Real, 1, npts> abartab; | ||
AMREX_GPU_MANAGED amrex::Array1D<amrex::Real, 1, npts> ebtab; | ||
AMREX_GPU_MANAGED amrex::Array1D<amrex::Real, 1, npts> wratetab; | ||
AMREX_GPU_MANAGED amrex::Array1D<amrex::Real, 1, npts> abartab; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
different indent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
T_values=Ts, | ||
Ye_values=yes, | ||
comp_reduction_func=get_aprox19_comp, | ||
verbose=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this script is specifically for aprox19, is it better to just move it there and change outfile=nse_aprox19.tbl
?. Then I guess README also needs to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my goal is to eventually make it support any net. I will make it clear in the README how to switch it to a different net.
A new NSE table for aprox19 created with pynucastro replaces the original NSE table.
This has mostly the same range of validity, but has finer dlogT spacing and also tabulates
dAbar/dt, d<B/A>/dt, and e_nu.
This also contains a notebook that can be used to inspect the true NSE result from pynucastro at an arbitrary thermodynamic point.
Finally, we include the python script that generates the table.