Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #217 | Update tab bar indicator color to match app theme #219

Merged

Conversation

navaneeth0041
Copy link
Contributor

@navaneeth0041 navaneeth0041 commented Dec 28, 2024

Update tab bar indicator color to match app theme

Description

Changed default blue indicator color in tab bars to app's primary color for visual consistency across the application.

Fixes #217

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Tested the following scenarios:

  • Tab indicator color matches app's primary color
  • Color consistency maintained during tab switches
  • Tab functionality works as expected
  • Theme changes apply correctly

Please include screenshots below if applicable.
Screenshot_20241229_025418
Screenshot_20241229_025433

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

Copy link
Collaborator

@mdmohsin7 mdmohsin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdmohsin7 mdmohsin7 merged commit 14c025f into AOSSIE-Org:develop Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TabBar indicator color not matching application theme
2 participants