Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing the new artoolkit5-js with Allow Memory Growth #358

Merged
merged 7 commits into from
Nov 18, 2021

Conversation

kalwalt
Copy link
Member

@kalwalt kalwalt commented Nov 16, 2021

⚠️ All PRs have to be done versus 'dev' branch, so be aware of that, or we'll close your issue ⚠️

What kind of change does this PR introduce?

This is a bugfix, i am experimenting with the ES6 feature dev branch.

Can it be referenced to an Issue? If so what is the issue # ?
See issue #357 and AR-js-org/artoolkit5-js#11

How can we test it?

Test the examples in the aframe and three.js folder, in particular nft examples are much affected

Summary

Sometimes running the examples (ES6 feature in dev branch) with a Mobile device i get a out of Memory issue as described in AR-js-org/artoolkit5-js#11 this occur especailly with the NFT examples.

Does this PR introduce a breaking change?
Not to the final user. Changes occur internally arjs-context.js and the different artooolkit5-js package.

Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
Tested with:

  • Oppo A72 running Android 11.1 and Chrome 95.
  • Wiko View running Android 7.1.2 Chrome 95.0.4638.74 .

Other information
This issue occurs only in Mobile devices.
This PR also remove the double artoolkit init in the Context class and in the worker. This is not necesssary because we init artoolkit already in the ARController _initialize https://github.com/AR-js-org/artoolkit5-js/blob/aa21c379d51b08e9a0d52b26f9f6928084ddb844/src/ARController.js#L1260

task to complete

@kalwalt kalwalt added bug Something isn't working enhancement New feature or request ES6 module AR.js as a ES6 module labels Nov 16, 2021
@kalwalt kalwalt self-assigned this Nov 16, 2021
@kalwalt
Copy link
Member Author

kalwalt commented Nov 17, 2021

I need to test also with another Mobile device, but i think this should solve the issue.

@kalwalt kalwalt merged commit 5f783e2 into dev Nov 18, 2021
@kalwalt kalwalt deleted the fix-WebAssembly-issue branch December 22, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request ES6 module AR.js as a ES6 module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant