Testing the new artoolkit5-js with Allow Memory Growth #358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is a bugfix, i am experimenting with the ES6 feature
dev
branch.Can it be referenced to an Issue? If so what is the issue # ?
See issue #357 and AR-js-org/artoolkit5-js#11
How can we test it?
Test the examples in the aframe and three.js folder, in particular nft examples are much affected
Summary
Sometimes running the examples (ES6 feature in dev branch) with a Mobile device i get a out of Memory issue as described in AR-js-org/artoolkit5-js#11 this occur especailly with the NFT examples.
Does this PR introduce a breaking change?
Not to the final user. Changes occur internally arjs-context.js and the different artooolkit5-js package.
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
Tested with:
Other information
This issue occurs only in Mobile devices.
This PR also remove the double artoolkit init in the Context class and in the worker. This is not necesssary because we init artoolkit already in the ARController
_initialize
https://github.com/AR-js-org/artoolkit5-js/blob/aa21c379d51b08e9a0d52b26f9f6928084ddb844/src/ARController.js#L1260task to complete