Sophie/Emily's Adagram Submission #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merging emily stuff
dHelmgren
reviewed
Sep 28, 2020
There was a problem hiding this comment.
Adagrams
Major Learning Goals/Code Review
| Criteria | yes/no, and optionally any details/lines of code to reference |
|---|---|
| Correctly creates and calls methods with proper syntax (parameters, return statements, etc.) | ✔️ |
| Uses correct syntax for conditional logic and iteration | ✔️ |
| Practices git with at least 3 small commits and meaningful commit messages | ✔️ |
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures |
✔️ |
| Practices pair programming; the reflection question on pair programming is answered | ✔️ |
Functional Requirements
| Functional Requirement | yes/no |
|---|---|
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) |
✔️ |
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass |
✔️ |
Utilizes unit tests to verify code; all tests for score_word pass |
✔️ |
Utilizes unit tests to verify code; all tests for highest_score_from pass |
✔️ |
Overall Feedback
| Overall Feedback | Criteria | yes/no |
|---|---|---|
| Green (Meets/Exceeds Standards) | 4+ in Code Review && 3+ in Functional Requirements | ✔️ |
| Yellow (Approaches Standards) | 3+ in Code Review && 2+ in Functional Requirements | |
| Red (Not at Standard) | 0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging |
Code Style Bonus Awards
| Quality | Yes? |
|---|---|
| Perfect Indentation | ✅ |
| Logical/Organized | ✅ |
Comment on lines
+89
to
+95
| "A" => 1, "E" => 1, "I" => 1, "O" => 1, "U" => 1, "L" => 1, "N" => 1, "R" => 1, "S" => 1, "T" => 1, | ||
| "D" => 2, "G" => 2, | ||
| "B" => 3, "C" => 3, "M" => 3, "P" => 3, | ||
| "F" => 4, "H" => 4, "V" => 4, "W" => 4, "Y" => 4, | ||
| "K" => 5, | ||
| "J" => 8, "X" => 8, | ||
| "Q" => 10, "Z" => 10 |
There was a problem hiding this comment.
Interesting that y'all chose two different hash styles in this assignment. IMO this kind of inconsistency can create readability problems, so keep an eye out for that!
| result = is_in_english_dict?(input) | ||
| expect(result).must_equal false | ||
|
|
||
| input = "appple" |
There was a problem hiding this comment.
you never eaten an appple before? \j
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Adagrams
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
What are the advantages of using git when collaboratively working on one code base? | Git is great for keeping track of the history of the file after each edit, especially when you're collaborating with someone and you need to see all the changes your partner/group has made. This is better than emailing your code back and forth!
What kind of relationship did you and your pair have with the unit tests? | It was great reviewing the tests together because we tackled all the errors and failures as a team. We examined one error or fail at a time. Sophie was quick and great at finding the bugs in resolving the errors/fails.
Does your code use any methods from the
Enumerablemixin? If so, where and why was it helpful? | We did try using enumerables when we were brainstorming, but we ended up taking them out in our code. It was challenging to keep track of all the new hashes, so it was easier to process the code by typing out hash = Hash.new, for example.What was one method you and your pair used to debug code? | It was helpful to read through the errors/fails after testing the methods. That way, we were able to focus on one error/fail, and trace back to our code to see where the bug might've been. Rake!
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? | We were both stressed at the beginning of the week and both observed that it was hard to think out loud and code and communicate at the same time. But by mid week our code was working better and we had a better grasp of how testing works. We also found it helpful to send code snippets to each other via slack, and reach out to instructors for help.