forked from AdaGold/exquisite-react
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Water - Beatrice #31
Open
Beatress
wants to merge
6
commits into
Ada-C14:master
Choose a base branch
from
Beatress:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Water - Beatrice #31
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
034e443
Added state to components I think will need it
Beatress f01bc7c
Got PlayerSubmissionForm to dynamically generate the form based on th…
Beatress b5e7fde
Have a working controlled React form
Beatress d7ca5b6
wave 1 complete
Beatress 3b8fdc4
wave 2 complete
Beatress b305a3a
Game finished
Beatress File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,11 @@ | |
text-align: center; | ||
font-style: italic; | ||
} | ||
|
||
.visible { | ||
visibility: visible; | ||
} | ||
|
||
.hidden { | ||
display: none; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,10 @@ import FinalPoem from './FinalPoem'; | |
import RecentSubmission from './RecentSubmission'; | ||
|
||
const Game = () => { | ||
const [poem, setPoem] = useState([]); | ||
const [currentPlayer, setCurrentPlayer] = useState(1); | ||
const [isSubmitted, setIsSubmitted] = useState(false); | ||
|
||
const exampleFormat = FIELDS.map((field) => { | ||
if (field.key) { | ||
return field.placeholder; | ||
|
@@ -13,6 +17,41 @@ const Game = () => { | |
} | ||
}).join(' '); | ||
|
||
const enterLineToPoem = (words) => { | ||
// Use words object to fill in fields and join into string | ||
let newLine = FIELDS.map((field, i) => { | ||
if (typeof field === 'string') { | ||
return field; | ||
} else { | ||
return words[field.key]; | ||
} | ||
}).join(' '); | ||
|
||
const newPoem = [...poem, newLine]; | ||
|
||
setPoem(newPoem); | ||
|
||
// Advance current player count | ||
setCurrentPlayer(currentPlayer + 1); | ||
}; | ||
|
||
// Function to check if recent submission should be shown | ||
const showRecentSubmission = () => { | ||
if (poem.length > 0 && !isSubmitted) { | ||
return true | ||
} else { | ||
return false | ||
} | ||
}; | ||
|
||
// Function to end game and reveal poem + hide non-relevant elements | ||
const revealPoem = () => { | ||
setIsSubmitted(true); | ||
}; | ||
|
||
// TODO remove | ||
console.log(isSubmitted); | ||
|
||
return ( | ||
<div className="Game"> | ||
<h2>Game</h2> | ||
|
@@ -25,12 +64,15 @@ const Game = () => { | |
{ exampleFormat } | ||
</p> | ||
|
||
<RecentSubmission /> | ||
<div className={showRecentSubmission() ? 'visible' : 'hidden'}> | ||
<RecentSubmission submission={poem[poem.length-1]}/> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just note that if |
||
</div> | ||
|
||
<PlayerSubmissionForm /> | ||
|
||
<FinalPoem /> | ||
<div className={isSubmitted ? 'hidden' : 'visible'}> | ||
<PlayerSubmissionForm index={currentPlayer} fields={FIELDS} sendSubmission={enterLineToPoem} /> | ||
</div> | ||
|
||
<FinalPoem submissions={poem} isSubmitted={isSubmitted} revealPoem={revealPoem}/> | ||
</div> | ||
); | ||
} | ||
|
@@ -63,7 +105,10 @@ const FIELDS = [ | |
key: 'noun2', | ||
placeholder: 'noun', | ||
}, | ||
'.', | ||
{ | ||
key: 'adv2', | ||
placeholder: 'adverb', | ||
} | ||
]; | ||
|
||
export default Game; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're hiding the content based on CSS while the test just assumes it's not rendered at all, which is why the test fails.