Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cuda build #171

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Fix cuda build #171

merged 1 commit into from
Apr 22, 2022

Conversation

krzysg
Copy link
Member

@krzysg krzysg commented Apr 22, 2022

Since same changes introduced in PR #169 and #163 ParticleDataGpu class was explicitly instantiated more than once.

@krzysg krzysg changed the base branch from master to develop April 22, 2022 15:00
@krzysg krzysg requested a review from joeljonsson April 22, 2022 15:01
joeljonsson
joeljonsson approved these changes Apr 22, 2022
View reviewed changes
Copy link
Collaborator

@joeljonsson joeljonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Guess I should have rebased those PRs. We also need to add cuda build/tests to the CI workflow

@krzysg krzysg merged commit 4953f8d into develop Apr 22, 2022
@krzysg krzysg deleted the fixCudaBuild branch April 22, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeljonsson joeljonsson joeljonsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzysg @joeljonsson