AD-219 Enhance Error Handling for Payment and Order Placement Steps #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjaneta
requested changes
Apr 2, 2024
| @@ -105,16 +109,18 @@ public ResponseEntity<AddressData> updateDeliveryAddress(@RequestBody AddressFor | |||
|
|
|||
| return ResponseEntity.status(HttpStatus.OK).build(); | |||
| } else { | |||
| return ResponseEntity.status(HttpStatus.BAD_REQUEST).build(); | |||
| ErrorResponse errorResponse = new ErrorResponse(""); | |||
There was a problem hiding this comment.
should we send empty error code?
| @@ -15,3 +15,6 @@ checkout.error.authorization.payment.failed=Payment failed | |||
| checkout.error.authorization.payment.rejected=Your payment was rejected | |||
| checkout.error.authorization.payment.timeout=Payment processing took longer than expected. Please check again in few minutes. | |||
| checkout.error.authorization.payment.pending=Your payment is being processed | |||
|
|
|||
| checkout.error.default=Sorry, there was a problem, please try again later | |||
There was a problem hiding this comment.
What about sample translation for DE?
| @@ -21,4 +21,8 @@ | |||
| margin-top: 30px; | |||
| padding: 15px; | |||
| border-radius: 12px; | |||
| } | |||
|
|
|||
| .alert{ | |||
| } | ||
| } | ||
| return noRedirect; | ||
| } | ||
|
|
||
| render() { | ||
| if (this.state.redirectToShippingAddress) { | ||
| return <Navigate to={routes.shippingAddress}/> | ||
| return <Navigate to={routes.shippingAddress + "/missingDataRedirect"}/> |
There was a problem hiding this comment.
It can be set in routes.ts as new routes
|
|
||
| export class StepBase extends React.Component<{}, null> { | ||
|
|
||
| // private readonly notificationsWithRedirect: Notification[] |
There was a problem hiding this comment.
Remove all commented out code. Optionally move fetchCartData to each step as it was before
| case "notifications/removeNotificationsWithoutRedirect": { | ||
| return notifications.filter((notification) => notification.isRedirect) | ||
| } | ||
| case "notifications/removeNotificationsFromList": { |
There was a problem hiding this comment.
We don't use this functionality so it might be removed
| interface RemoveNotificationsWithoutRedirect extends Action<"notifications/removeNotificationsWithoutRedirect"> { | ||
| } | ||
|
|
||
| interface RemoveNotificationsFromList extends PayloadAction<"notifications/removeNotificationsFromList", Notification[]> { |
| checkoutStep={CheckoutSteps.SHIPPING_METHOD}><CheckoutStepWrapper><ShippingMethodStep/></CheckoutStepWrapper></NotificationWrapper></TranslationWrapper>, | ||
| }, | ||
| { | ||
| path: routes.shippingMethod + "/missingDataRedirect", |
There was a problem hiding this comment.
After creating route in routes.ts it can be used here
| element: <TranslationWrapper><NotificationWrapper | ||
| checkoutStep={CheckoutSteps.SHIPPING_ADDRESS}><CheckoutStepWrapper><ShippingAddressStep/></CheckoutStepWrapper></NotificationWrapper></TranslationWrapper>, | ||
| }, { | ||
| path: routes.shippingAddress + "/missingDataRedirect", |
There was a problem hiding this comment.
After creating route in routes.ts it can be used here
…h AdyenControllerExceptionHandler. Fixed redirect routes.
pjaneta
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created ErrorHandler with basic logic to catch errors in React services. Wrapped every step with NotificationWrapper so now it displays Notification Bars on top. Added some error codes for translations. Created ErrorResponse java class to return error codes and fields containing errors (if required).
Tested scenarios
Tested error handling for:
Fixed issue: AD-219