Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-9240] Refactor the process to download the Apple Pay domain association file, and change the misleading UI field label #2818

Merged
merged 9 commits into from
Dec 24, 2024
Merged

[ECP-9240] Refactor the process to download the Apple Pay domain association file, and change the misleading UI field label #2818

merged 9 commits into from
Dec 24, 2024

Conversation

candemiralp
Copy link
Member

@candemiralp candemiralp commented Dec 3, 2024 •
edited by sena1482
Loading

Description

  • Refactored the way the plugin downloads the Apple Pay domain association file to introduce a more reliable process. Previously, the plugin downloaded the domain association file from Adyen Docs, which caused errors when the Docs link changed.
  • In the Adobe Commerce admin panel, renamed the misleading Apple Pay Certificate field to Apple Pay domain association file.

Screenshot 2024-12-03 at 09 04 15

Tested scenarios

  • Download and validate Apple Pay domain association file

@candemiralp candemiralp requested a review from a team as a code owner December 3, 2024 08:04
@candemiralp candemiralp mentioned this pull request Dec 3, 2024
Closed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@candemiralp candemiralp added the Fix Indicates a bug fix label Dec 24, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@candemiralp candemiralp merged commit 09dfcf3 into main Dec 24, 2024
14 of 15 checks passed
@candemiralp candemiralp deleted the ECP-9240 branch December 24, 2024 09:48
@AdyenAutomationBot AdyenAutomationBot mentioned this pull request Dec 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acampos1916 acampos1916 acampos1916 approved these changes

@SushmitaThakur SushmitaThakur Awaiting requested review from SushmitaThakur

Assignees
No one assigned
Labels
Fix Indicates a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@candemiralp @acampos1916 @SushmitaThakur