Add to array method in mustache templates and assert it's faster #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jillingk
added
the
breaking change
jillingk
force-pushed
the
to-array-mustache
branch
from
e537008 to
1e75b28
Compare
hossam-adyen
approved these changes
Feb 19, 2024
|
wboereboom
approved these changes
Feb 22, 2024
|
We can safely ignore sonarcloud here, as it is triggering on generated code |
Merged
wboereboom
added
Feature
and removed
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the toArray() method in every model (tested in checkout) to make it easier to parse models to arrays. Tested that this is in fact faster that parsing to json string and back to array (speed up of about 2x).