Stop calling sanitizeResponse twice during the payment response handl… #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sponglord
requested review from
marcperez,
pabloai,
m1aw,
ribeiroguilherme and
longyulongyu
as code owners
|
Size Change: -25 B (0%) Total Size: 769 kB
ℹ️ View Unchanged
|
size-limit report 📦
|
|
ribeiroguilherme
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing process
Summary
As discussed previously - it is not necessary for the
UIElementshandleResponsefunction to callsanitizeResponseon the passed object, since this function has already been run earlier in the handling-the-payments-response, or, handling-the-details-response, chains.This also applies to it's use in the
ApplePayandGooglePaycomponentsTested scenarios
unit tests pass