Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] new version splitted in modules and build as UMD #14

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

JSteunou
Copy link

@JSteunou JSteunou commented Feb 7, 2016

I might need some help on this. This library is very procedural and inconsistent in the writing. Very hard to find out how to organize it some times.

I add some TODO to point out some of the things I noticed.

I still have to add

  • npm scripts
  • webpack config + babel
  • move the index.js to blockrain.js and make the index.js a jquery plugin factory of blockrain class
  • finally build, cross fingers, debug, fix

@RobertoGonzalez
Copy link
Member

Love the ES6 and modular themes!
For the time being I'd recommend against a large refactor. The original code on which blockrain is based has a convoluted structure and making it more modular (like it should be) pretty much requires rewriting the entire thing, since the renderer, game logic and other things are all joined together in odd ways.
It can certainly be (and should be) done, but since the plugin is mostly feature complete, we are not messing that much with the source these days. That's pretty much the reason why most of the more recent changes are patches instead of decent rewrites.

I'm more than happy to answer questions about the code to help you go forward with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants