Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade kafka and other libs #287

Merged
merged 2 commits into from
May 29, 2024
Merged

Upgrade kafka and other libs #287

merged 2 commits into from
May 29, 2024

Conversation

muralibasani
Copy link
Contributor

This PR does the following.

  • Upgrades kafka version from 2.8.0 to 3.5.0 which removes commons lang3 dependency. Had to add the dependency manually
  • Add apache commons dependency
  • Upgrade opensearch version and testContainer versions

@muralibasani muralibasani requested review from a team as code owners May 28, 2024 14:45
reta
reta reviewed May 28, 2024
View reviewed changes
build.gradle Outdated
openSearchVersion = "2.13.0"
kafkaVersion = "3.5.0"
apacheCommonsLangVersion = "3.14.0"
slf4jVersion = "2.0.13"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still use Slf4j 1.7.x in OpenSearch:

Suggested change
slf4jVersion = "2.0.13"
slf4jVersion = "1.7.36"

Claudenw
Claudenw previously approved these changes May 29, 2024
View reviewed changes
Copy link

@Claudenw Claudenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I would change the version as @reta suggested.

@muralibasani
Copy link
Contributor Author

@Claudenw @reta thanks for the review. Updated PR.

Claudenw
Claudenw approved these changes May 29, 2024
View reviewed changes
Copy link

@Claudenw Claudenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes

@willyborankin willyborankin merged commit 21c100f into main May 29, 2024
16 checks passed
@willyborankin willyborankin deleted the minor-changes2 branch May 29, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta left review comments

@Claudenw Claudenw Claudenw approved these changes

@willyborankin willyborankin willyborankin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muralibasani @willyborankin @reta @Claudenw