feat(chrome-devtools): add a panel to see the current value of all available facts #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit fd8945b.
☁️ Nx Cloud last updated this comment at |
github-actions
bot
added
enhancement
fpaul-1A
force-pushed
the
feat/devtools-facts-snapshot
branch
2 times, most recently
from
4175037 to
3fca27f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
fpaul-1A
changed the title
...ges/@o3r/rules-engine/src/components/rules-engine/facts-snapshot/facts-snapshot.component.ts
Outdated
Show resolved
Hide resolved
packages/@o3r/rules-engine/src/components/rules-engine/facts-snapshot/facts-snapshot.style.scss
Outdated
Show resolved
Hide resolved
...es/@o3r/rules-engine/src/components/rules-engine/facts-snapshot/facts-snapshot.template.html
Outdated
Show resolved
Hide resolved
fpaul-1A
force-pushed
the
feat/devtools-facts-snapshot
branch
from
3fca27f to
980e5c8
Compare
kpanot
reviewed
Jan 22, 2025
...ges/@o3r/rules-engine/src/components/rules-engine/facts-snapshot/facts-snapshot.component.ts
Outdated
Show resolved
Hide resolved
...ges/@o3r/rules-engine/src/components/rules-engine/facts-snapshot/facts-snapshot.component.ts
Outdated
Show resolved
Hide resolved
fpaul-1A
force-pushed
the
feat/devtools-facts-snapshot
branch
from
980e5c8 to
64fc196
Compare
kpanot
previously approved these changes
Jan 23, 2025
fpaul-1A
force-pushed
the
feat/devtools-facts-snapshot
branch
from
64fc196 to
fd8945b
Compare
matthieu-crouzet
approved these changes
Jan 24, 2025
mrednic-1A
approved these changes
Jan 24, 2025
cpaulve-1A
reviewed
Jan 24, 2025
| <ul class="ruleset-panel-category-body"> | ||
| @for (action of actions; track $index) { | ||
| <li> | ||
| @if (isActionBlock(action)) { |
There was a problem hiding this comment.
Is it possible to use a predicate in a pipe and avoid call to functions in the template ?
There was a problem hiding this comment.
it doesn't seem feasible to do type predicate inference using Angular pipes (as far as I can tell)
the performance impact is very low here as the function is just accessing a property of the object and the scope of the change detection is limited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Related issues
- No issue associated -