added pool_pre_ping=True to create_engine for database stability (#566)

* added pool_pre_ping=True to create_engine for database stability * More descripting CHANGES message
Amsterdam · Nov 12, 2024 · 828bca6 · 828bca6
1 parent 283a0cb
commit 828bca6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,3 +1,7 @@
+# 2024-10-12 (6.1.2)
+
+* Added pool_pre_ping=True to fix connection pool issues.
+
 # 2024-10-01 (6.1.1)
 
 * Fixed crash in `schema permissions apply` for tables that don't have a sequence in the database.

diff --git a/setup.cfg b/setup.cfg
@@ -1,6 +1,6 @@
 [metadata]
 name = amsterdam-schema-tools
-version = 6.1.1
+version = 6.1.2
 url = https://github.com/amsterdam/schema-tools
 license = Mozilla Public 2.0
 author = Team Data Diensten, van het Dataplatform onder de Directie Digitale Voorzieningen (Gemeente Amsterdam)

diff --git a/src/schematools/cli.py b/src/schematools/cli.py
@@ -112,7 +112,7 @@
 
 def _get_engine(db_url: str, pg_schemas: list[str] | None = None) -> sqlalchemy.engine.Engine:
     """Initialize the SQLAlchemy engine, and report click errors."""
-    kwargs = {}
+    kwargs = {"pool_pre_ping": True}
     if pg_schemas is not None:
         csearch_path = ",".join(pg_schemas + ["public"])
         kwargs["connect_args"] = {"options": f"-csearch_path={csearch_path}"}