feat: add all scripts from multisig to governance #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,59 @@ | |||
| pragma solidity ^0.8.19; | |||
|
|
|||
There was a problem hiding this comment.
I encountered that in the angle-multisig, maybe better to create interfaces in respective repo to not copy paste evrywhere
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=======================================
Coverage 85.49% 85.49%
=======================================
Files 7 7
Lines 255 255
=======================================
Hits 218 218
Misses 37 37 ☔ View full report in Codecov by Sentry. |
GuillaumeNervoXS
force-pushed
the
feat/multisig-scripts
branch
from
b968164 to
3af5b78
Compare
0xtekgrinder
commented
Jan 15, 2024
Comment on lines
+192
to
+194
| # if [[ $execute == "yes" ]]; then | ||
| # forge script scripts/interaction/Propose.s.sol:Propose --fork-url $mainnet_uri --broadcast | ||
| # fi |
There was a problem hiding this comment.
don't forget to uncomment this
| @@ -204,6 +204,7 @@ contract SimulationSetup is Test { | |||
| HELPERS | |||
| //////////////////////////////////////////////////////////////////////////////////////////////////////////////////*/ | |||
|
|
|||
| // TODO USE IT | |||
There was a problem hiding this comment.
remove this forgotten comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.