Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve a noisy cmake deprecation warning when using latest cmake version #1096

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

spoonincode
Copy link
Member

latest cmake 3.31 has started to produce warnings such as

CMake Deprecation Warning at libraries/eos-vm/CMakeLists.txt:5 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

A variation of this is printed over 10 times for spring. Resolve this warning for projects we control. Needs also,
AntelopeIO/abieos#36
AntelopeIO/appbase#38
AntelopeIO/chainbase#55
AntelopeIO/eos-vm#29

@ericpassmore
Copy link
Contributor

Note:start
category: Chores
component: Internal
summary: Resolve cmake warnings on future version support.
Note:end

@spoonincode
Copy link
Member Author

Thanks for the reviews; I still need another one on the linked AntelopeIO/abieos#36. It will help getting this merged before submodules continue to drift out which is a real pain.

@spoonincode
Copy link
Member Author

thanks

@spoonincode spoonincode merged commit 0e60eac into main Jan 16, 2025
36 checks passed
@spoonincode spoonincode deleted the cmake_minvers_warn_fixes branch January 16, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants