rem - brk|doc - Removed fancy console writers

--- To follow Terminaux's deprecation of the old method-based writers, we've decided to remove fancy console writers, except those that are really important. --- Type: rem Breaking: True Doc Required: True Backport Required: False Part: 1/1
Aptivi · Dec 26, 2024 · d982cd2 · d982cd2
1 parent a23951c
commit d982cd2
Show file tree

Hide file tree

Showing 32 changed files with 156 additions and 2,173 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -23,7 +23,7 @@
           changes!
         -->
         <NitrocidModAPIVersionMajor>3.0.27</NitrocidModAPIVersionMajor>
-        <NitrocidModAPIVersionChangeset>17</NitrocidModAPIVersionChangeset>
+        <NitrocidModAPIVersionChangeset>18</NitrocidModAPIVersionChangeset>
 
         <!-- The above two properties are to be installed to the file version -->
         <NitrocidModAPIVersion>$(NitrocidModAPIVersionMajor).$(NitrocidModAPIVersionChangeset)</NitrocidModAPIVersion>

diff --git a/public/Nitrocid.Addons/Nitrocid.Extras.Chemistry/Commands/Element.cs b/public/Nitrocid.Addons/Nitrocid.Extras.Chemistry/Commands/Element.cs
@@ -23,6 +23,8 @@
 using Nitrocid.ConsoleBase.Writers;
 using Nitrocid.Languages;
 using Nitrocid.Shell.ShellBase.Commands;
+using Terminaux.Writer.ConsoleWriters;
+using Terminaux.Writer.CyclicWriters;
 
 namespace Nitrocid.Extras.Chemistry.Commands
 {
@@ -54,19 +56,30 @@ public override int Execute(CommandParameters parameters, ref string variableVal
             }
 
             // Print information
-            TextWriters.WriteListEntry(Translate.DoTranslation("Name"), substance.Name, KernelColorType.ListEntry, KernelColorType.ListValue);
-            TextWriters.WriteListEntry(Translate.DoTranslation("Atomic number"), $"{substance.AtomicNumber}", KernelColorType.ListEntry, KernelColorType.ListValue);
-            TextWriters.WriteListEntry(Translate.DoTranslation("Atomic mass"), $"{substance.AtomicMass}", KernelColorType.ListEntry, KernelColorType.ListValue);
-            TextWriters.WriteListEntry(Translate.DoTranslation("Symbol"), substance.Symbol, KernelColorType.ListEntry, KernelColorType.ListValue);
-            TextWriters.WriteListEntry(Translate.DoTranslation("Summary"), substance.Summary, KernelColorType.ListEntry, KernelColorType.ListValue);
-            TextWriters.WriteListEntry(Translate.DoTranslation("Phase"), $"{substance.Phase}", KernelColorType.ListEntry, KernelColorType.ListValue);
-            TextWriters.WriteListEntry(Translate.DoTranslation("Position in the periodic table"), $"{substance.Period}, {substance.Group}", KernelColorType.ListEntry, KernelColorType.ListValue);
-            TextWriters.WriteListEntry(Translate.DoTranslation("Position in coordinates"), $"{substance.PosX} (w: {substance.WPosX}), {substance.PosY} (w: {substance.WPosY})", KernelColorType.ListEntry, KernelColorType.ListValue);
-            TextWriters.WriteListEntry(Translate.DoTranslation("Discoverer"), substance.Discoverer, KernelColorType.ListEntry, KernelColorType.ListValue);
-            TextWriters.WriteListEntry(Translate.DoTranslation("Named by"), substance.NamedBy, KernelColorType.ListEntry, KernelColorType.ListValue);
-            TextWriters.WriteListEntry(Translate.DoTranslation("Electron configuration"), substance.ElectronConfiguration, KernelColorType.ListEntry, KernelColorType.ListValue);
+            WriteListEntry(Translate.DoTranslation("Name"), substance.Name, KernelColorType.ListEntry, KernelColorType.ListValue);
+            WriteListEntry(Translate.DoTranslation("Atomic number"), $"{substance.AtomicNumber}", KernelColorType.ListEntry, KernelColorType.ListValue);
+            WriteListEntry(Translate.DoTranslation("Atomic mass"), $"{substance.AtomicMass}", KernelColorType.ListEntry, KernelColorType.ListValue);
+            WriteListEntry(Translate.DoTranslation("Symbol"), substance.Symbol, KernelColorType.ListEntry, KernelColorType.ListValue);
+            WriteListEntry(Translate.DoTranslation("Summary"), substance.Summary, KernelColorType.ListEntry, KernelColorType.ListValue);
+            WriteListEntry(Translate.DoTranslation("Phase"), $"{substance.Phase}", KernelColorType.ListEntry, KernelColorType.ListValue);
+            WriteListEntry(Translate.DoTranslation("Position in the periodic table"), $"{substance.Period}, {substance.Group}", KernelColorType.ListEntry, KernelColorType.ListValue);
+            WriteListEntry(Translate.DoTranslation("Position in coordinates"), $"{substance.PosX} (w: {substance.WPosX}), {substance.PosY} (w: {substance.WPosY})", KernelColorType.ListEntry, KernelColorType.ListValue);
+            WriteListEntry(Translate.DoTranslation("Discoverer"), substance.Discoverer, KernelColorType.ListEntry, KernelColorType.ListValue);
+            WriteListEntry(Translate.DoTranslation("Named by"), substance.NamedBy, KernelColorType.ListEntry, KernelColorType.ListValue);
+            WriteListEntry(Translate.DoTranslation("Electron configuration"), substance.ElectronConfiguration, KernelColorType.ListEntry, KernelColorType.ListValue);
             return 0;
         }
 
+        private void WriteListEntry(string entry, string value, KernelColorType entryColor, KernelColorType valueColor)
+        {
+            var listEntry = new ListEntry()
+            {
+                Entry = entry,
+                Value = value,
+                KeyColor = KernelColorTools.GetColor(entryColor),
+                ValueColor = KernelColorTools.GetColor(valueColor),
+            };
+            TextWriterRaw.WritePlain(listEntry.Render());
+        }
     }
 }
diff --git a/public/Nitrocid.Addons/Nitrocid.Extras.GitShell/Git/Commands/Diff.cs b/public/Nitrocid.Addons/Nitrocid.Extras.GitShell/Git/Commands/Diff.cs
@@ -24,6 +24,7 @@
 using Nitrocid.ConsoleBase.Colors;
 using Nitrocid.Languages;
 using Terminaux.Writer.ConsoleWriters;
+using Terminaux.Writer.FancyWriters;
 
 namespace Nitrocid.Extras.GitShell.Git.Commands
 {
@@ -66,7 +67,7 @@ public override int Execute(CommandParameters parameters, ref string variableVal
                 var renamed = tree.Renamed;
 
                 // List the general changes
-                TextFancyWriters.WriteSeparator(Translate.DoTranslation("General changes in") + $" {GitShellCommon.RepoName}:", KernelColorType.ListTitle);
+                SeparatorWriterColor.WriteSeparatorColor(Translate.DoTranslation("General changes in") + $" {GitShellCommon.RepoName}:", KernelColorTools.GetColor(KernelColorType.ListTitle));
                 foreach (var change in modified)
                     TextWriters.Write($"[M] * {change.Path}", KernelColorType.ListEntry);
                 foreach (var change in added)
@@ -82,7 +83,7 @@ public override int Execute(CommandParameters parameters, ref string variableVal
 
             if (doPatch)
             {
-                TextFancyWriters.WriteSeparator(Translate.DoTranslation("Content changes in") + $" {GitShellCommon.RepoName}:", KernelColorType.ListTitle);
+                SeparatorWriterColor.WriteSeparatorColor(Translate.DoTranslation("Content changes in") + $" {GitShellCommon.RepoName}:", KernelColorTools.GetColor(KernelColorType.ListTitle));
                 TextWriterColor.Write(patch.Content);
             }
 

diff --git a/public/Nitrocid.Templates/templates/KSMod/ModName.cs b/public/Nitrocid.Templates/templates/KSMod/ModName.cs
@@ -10,7 +10,7 @@ public class ModName : IMod
         public string Name { get; set; } = "My Mod";
         public string Version { get; set; } = "1.0.0";
 
-        public Version MinimumSupportedApiVersion => new(3, 0, 27, 17);
+        public Version MinimumSupportedApiVersion => new(3, 0, 27, 18);
 
         public ReadOnlyDictionary<string, Delegate> PubliclyAvailableFunctions => null;