-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_HAL_ChibiOS: Added support for ZeroOne_Air flight controller #29022
base: master
Are you sure you want to change the base?
AP_HAL_ChibiOS: Added support for ZeroOne_Air flight controller #29022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# PI10 EXT1_CS CS | ||
|
||
# PWM output pins | ||
PI0 TIM5_CH4 TIM5 PWM(1) GPIO(50) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider:
PI0 TIM5_CH4 TIM5 PWM(1) GPIO(50) BIDIR
PH12 TIM5_CH3 TIM5 PWM(2) GPIO(51)
PH11 TIM5_CH2 TIM5 PWM(3) GPIO(52) BIDIR
PH10 TIM5_CH1 TIM5 PWM(4) GPIO(53)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I get it now, thanks!
Commit list needs cleaning up before merge. |
We've changed the content, please help us review it again, thanks |
AP_HAL_ChibiOS: Added support for our new ZeroOne_Air flight controller