Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with angular 17 #107

Open
mlditga opened this issue Dec 12, 2023 · 11 comments
Open

Compatibility with angular 17 #107

mlditga opened this issue Dec 12, 2023 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@mlditga
Copy link

mlditga commented Dec 12, 2023

Hello,
We are trying to use ngx-matomo with angular 17 but it seems that there is an issue with "@angular/router": "^17.0.6". We get this error: "NullInjectorError: No provider for ActivatedRoute!". It seems similar to this issue: #58.
Do you plan to release a version for angular 17 anytime soon? Or is there a workaround?
Thank you very much!

@tarlepp
Copy link

tarlepp commented Dec 29, 2023

Any update on this? Also this most likely relates to #108

@tarlepp
Copy link

tarlepp commented Jan 19, 2024

Angular 17.1.0 is out and this same issue still exists.

Anyone know if there is fix for this?

@tarlepp
Copy link

tarlepp commented Feb 16, 2024

Angular 17.2.0 is out and this issue is still open.

@marchein
Copy link

I am also interested in a fix.

@jerryzhch
Copy link

Me too

bdsl added a commit to thebiggive/donate-frontend that referenced this issue Mar 25, 2024
Intending to remove ngx-matomo because it's not compatible yet with
Angular 17

See Arnaud73/ngx-matomo#107 and notes on
ticket.
@tarlepp
Copy link

tarlepp commented Jun 18, 2024

Angular 18 is out, is there any change that @Arnaud73 could take a closer look of those open PR's which fixed this? Or is the only option to start to use another library for this?

@Arnaud73 Arnaud73 self-assigned this Jun 25, 2024
@Arnaud73 Arnaud73 added the enhancement New feature or request label Jun 25, 2024
@Arnaud73
Copy link
Owner

I am currently rewriting this library from scratch to make it fully compatible with Angular 18, with many aditional features I'm currently needing for integrating it into a very large app.

Expect version 3.0 to be published in the coming days.

The most curious of you can have a look at https://github.com/Arnaud73/ngx-matomo/tree/feature/angular-18_support for having a look at the breaking changes (library will be module-less, configuration options will be richer).

@tarlepp
Copy link

tarlepp commented Jun 26, 2024

Great news!

@cah-chad-smith03
Copy link

@Arnaud73 I appreciate you working on getting ng18 fully supported, but apps using ng17 still need the fix in order to use this library. Any chance feature/angular-17-upgrade will be approved?

Would rather use this library than have to fork/maintain a parallel branch just to be compatible with ng17. Thanks.

@tarlepp
Copy link

tarlepp commented Sep 23, 2024

@Arnaud73 any update on this?

@tarlepp
Copy link

tarlepp commented Nov 26, 2024

@Arnaud73 any update on this? This has been open almost one year now, so for me it looks like this repository is abandoned, please confirm that so we have clear message that this won't be happening at all, and we will need to start to look other options for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants