-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DON-950: Replace ngx-matomo library with ngx-matomo-client #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intending to remove ngx-matomo because it's not compatible yet with Angular 17 See Arnaud73/ngx-matomo#107 and notes on ticket.
bdsl
force-pushed
the
DON-950-remove-ngx-matomo
branch
from
March 25, 2024 15:59
edfbacb
to
4c550e1
Compare
bdsl
force-pushed
the
DON-950-remove-ngx-matomo
branch
from
March 26, 2024 12:36
973b99e
to
187a568
Compare
bdsl
force-pushed
the
DON-950-remove-ngx-matomo
branch
from
March 26, 2024 13:58
1a09066
to
dc2cabd
Compare
bdsl
force-pushed
the
DON-950-remove-ngx-matomo
branch
from
March 26, 2024 14:19
a3509e4
to
3f35471
Compare
bdsl
force-pushed
the
DON-950-remove-ngx-matomo
branch
from
March 26, 2024 14:48
0aac977
to
21f37a9
Compare
bdsl
changed the title
DON-950: Install ngx-matomo-client alongside ngx-matomo
DON-950: Replace ngx-matomo library with ngx-matomo-client
Mar 26, 2024
dorota-joanna
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @dorota-joanna . I think I'll wait until after #1510 is deployed before merging this to develop, so that I can do some testing of this with Matomo between deploying to staging and deploying to prod. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intending to remove ngx-matomo because it's not compatible yet with Angular 17
See Arnaud73/ngx-matomo#107 and notes on ticket.