Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DON-950: Replace ngx-matomo library with ngx-matomo-client #1506

Merged
merged 13 commits into from
Mar 27, 2024

Conversation

bdsl
Copy link
Contributor

@bdsl bdsl commented Mar 25, 2024

Intending to remove ngx-matomo because it's not compatible yet with Angular 17

See Arnaud73/ngx-matomo#107 and notes on ticket.

bdsl added 2 commits March 25, 2024 13:04
Intending to remove ngx-matomo because it's not compatible yet with
Angular 17

See Arnaud73/ngx-matomo#107 and notes on
ticket.
@bdsl bdsl force-pushed the DON-950-remove-ngx-matomo branch from edfbacb to 4c550e1 Compare March 25, 2024 15:59
@bdsl bdsl force-pushed the DON-950-remove-ngx-matomo branch from 973b99e to 187a568 Compare March 26, 2024 12:36
@bdsl bdsl force-pushed the DON-950-remove-ngx-matomo branch from 1a09066 to dc2cabd Compare March 26, 2024 13:58
@bdsl bdsl force-pushed the DON-950-remove-ngx-matomo branch from a3509e4 to 3f35471 Compare March 26, 2024 14:19
@bdsl bdsl force-pushed the DON-950-remove-ngx-matomo branch from 0aac977 to 21f37a9 Compare March 26, 2024 14:48
@bdsl bdsl changed the title DON-950: Install ngx-matomo-client alongside ngx-matomo DON-950: Replace ngx-matomo library with ngx-matomo-client Mar 26, 2024
@bdsl bdsl marked this pull request as ready for review March 26, 2024 15:19
Copy link
Contributor

@dorota-joanna dorota-joanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdsl
Copy link
Contributor Author

bdsl commented Mar 27, 2024

Thanks @dorota-joanna . I think I'll wait until after #1510 is deployed before merging this to develop, so that I can do some testing of this with Matomo between deploying to staging and deploying to prod.

@bdsl bdsl merged commit 3807e95 into develop Mar 27, 2024
4 checks passed
@bdsl bdsl deleted the DON-950-remove-ngx-matomo branch March 27, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants