Further fixes to get it operational.

ArtifactDB · May 23, 2024 · 6721695 · 6721695
1 parent a345f4d
commit 6721695
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/R/storeDelayedObject.R b/R/storeDelayedObject.R
@@ -320,7 +320,8 @@ chihaya_array_registry[["sparse matrix"]] <- function(handle, version, ...) {
     for (i in seq_along(svt)) {
         idx <- indptr[i] + seq_len(indptr[i+1] - indptr[i])
         if (length(idx)) {
-            svt[[i]] <- list(indices[idx], data[idx])
+            # As of version >= 1, data is first and indices are second.
+            svt[[i]] <- list(data[idx], indices[idx])
         }
     }
 

diff --git a/tests/testthat/test-storeDelayedObject.R b/tests/testthat/test-storeDelayedObject.R
@@ -181,7 +181,8 @@ test_that("sparse matrix saving handles dimnames", {
 
     temp <- saveDelayed(DelayedArray(X))
     roundtrip <- loadDelayed(temp)
-    expect_identical(as(X, "SVT_SparseMatrix"), roundtrip@seed)
+    expect_identical(type(X), type(roundtrip@seed))
+    expect_identical(X, as(roundtrip@seed, "dgCMatrix"))
 })
 
 test_that("sparse matrices are saved to external arrays if requested", {