Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Translation System #4

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

Zffu
Copy link
Contributor

@Zffu Zffu commented Apr 16, 2024

No description provided.

@AverageGithub
Copy link
Member

I'm quite unsure about this. The idea of translations is good, however I feel like having customizeable messages per envoy is a good sellingpoint of the plugin, and this would just remove that feature completely. Another thing is that we would have to migrate the messages from their existing messages.yml.

I think a better solution would be to have a locale option in the config, have a default lang folder, slap the current messages.yml there with the default translation (en_US.yml) and leave it at that with the previous system for messages.

I really appreciate your work, however next time please ask me (Discord: tomtom4945) about how things should be implemented, so we don't run unnecessary laps. :D

@Zffu
Copy link
Contributor Author

Zffu commented Apr 17, 2024

Thank you for your comments on this pull request. I will be probably closing it soon as the translation system is kinda overwelming to implement on an already released plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants