feat(esp-sync): queue data events sync to run once #3661
+147
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Since #3616, data events are grouped and handled in the same execution. This PR leverages that change to also optimize multiple syncs that different data events may trigger.
To restrict that behavior to data events only, this PR implements the feature from #3383 so we can be aware of whether we're running under a data event or not.
Syncs performed under data events should now only run once per email, containing the latest payload.
For debugging, the sync contexts are grouped to be logged, which can look like this:
To ensure we always have the most recent data, when running on shutdown the most recent contact data is fetched using a new
get_contact_data()
method, which was decoupled from thesync_contact()
method.How to test the changes in this Pull Request:
membership_status_active
,membership_saved
,reader_registered
)Newspack_Newsletters_Contacts::upsert
is loggedOther information: