-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(reader-revenue): add PayPal Payments gateway to wizard #3665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This took me way too long to test because I'm a ding-dong, but everything looks good! I spotted one non-PR-related issue (below) and one minor non-blocking issue 🙂
Not PR-related: when I initially enabled PayPal Payments, "Collect transaction fees" is disabled, but the checkbox appears on the front-end:
This is the same for other payment gateways (like Stripe), and the same on trunk; toggling on and off the setting fixes it so it seems to be some default weirdness!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dkoo! I retested the update, and the name is now consistent when the plugin isn't installed, and when it is 🎉
Hey @dkoo, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
@laurelfulford I opened a new PR for the transaction fee settings issue you described. |
# [5.13.0-alpha.3](v5.13.0-alpha.2...v5.13.0-alpha.3) (2025-01-24) ### Features * **reader-revenue:** add PayPal Payments gateway to wizard ([#3665](#3665)) ([1476eed](1476eed))
🎉 This PR is included in version 5.13.0-alpha.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Adds PayPal Payments to the list of fully-supported payment gateways in the Reader Revenue wizard.
How to test the changes in this Pull Request:
Other information: