Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reader-revenue): add PayPal Payments gateway to wizard #3665

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Jan 10, 2025

All Submissions:

Changes proposed in this Pull Request:

Adds PayPal Payments to the list of fully-supported payment gateways in the Reader Revenue wizard.

How to test the changes in this Pull Request:

  1. Start with a new testing site and install all required WooCommerce plugins (main Woo + Subscriptions).
  2. After completing setup, visit Reader Revenue and choose the "Newspack" platform if not already selected.
  3. Visit the Payment Methods tab and confirm you see PayPal Payments as an option here, and confirm that the "Learn more" link leads to the correct plugin info page:
Screenshot 2025-01-10 at 2 55 10 PM
  1. Enable PayPal Payments and confirm it installs and activates the plugin, then click "Connect" and confirm it leads you to the PayPal Payments plugin's onboarding page.
  2. Complete onboarding by connecting to a sandbox PayPal account (instructions)
  3. Go back to Reader Revenue > Payment Methods and confirm that the PayPal Payments card now shows it as connected in test mode. Confirm that the "Configure" button leads to the PayPal Payments plugin settings page.
Screenshot 2025-01-10 at 3 01 35 PM
  1. Confirm that you can complete a test transaction as a reader via modal checkout using PayPal. Test both with and without covering donation fees.
  2. Smoke test enabling and connecting Stripe and WooPayments, all links and buttons within those cards, and completing test transactions using those payment gateways both with and without covering fees, too.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 10, 2025
@dkoo dkoo self-assigned this Jan 10, 2025
@dkoo dkoo requested a review from a team as a code owner January 10, 2025 22:12
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This took me way too long to test because I'm a ding-dong, but everything looks good! I spotted one non-PR-related issue (below) and one minor non-blocking issue 🙂

Not PR-related: when I initially enabled PayPal Payments, "Collect transaction fees" is disabled, but the checkbox appears on the front-end:

CleanShot 2025-01-22 at 16 18 44

CleanShot 2025-01-22 at 16 19 19

This is the same for other payment gateways (like Stripe), and the same on trunk; toggling on and off the setting fixes it so it seems to be some default weirdness!

includes/class-plugin-manager.php Outdated Show resolved Hide resolved
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 23, 2025
@dkoo dkoo requested a review from laurelfulford January 23, 2025 22:02
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dkoo! I retested the update, and the name is now consistent when the plugin isn't installed, and when it is 🎉

@dkoo dkoo merged commit 1476eed into trunk Jan 24, 2025
9 checks passed
@dkoo dkoo deleted the feat/add-paypal-reader-revenue branch January 24, 2025 00:12
Copy link

Hey @dkoo, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

@dkoo
Copy link
Contributor Author

dkoo commented Jan 24, 2025

@laurelfulford I opened a new PR for the transaction fee settings issue you described.

matticbot pushed a commit that referenced this pull request Jan 24, 2025
# [5.13.0-alpha.3](v5.13.0-alpha.2...v5.13.0-alpha.3) (2025-01-24)

### Features

* **reader-revenue:** add PayPal Payments gateway to wizard ([#3665](#3665)) ([1476eed](1476eed))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.13.0-alpha.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants