chore: SmallSubgroupIPA tests #11106
Conversation
| @@ -0,0 +1,64 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
Introduced this struct to remove redundant pattern in pcs tests where we manually generate polys, commit to them, and evaluate them
| #include "barretenberg/transcript/transcript.hpp" | ||
| #include "commitment_key.test.hpp" | ||
|
|
||
| namespace bb { |
There was a problem hiding this comment.
We are already in commitment_schemes folder so this file and the other file don't need to be named pcs_*. I would also move them in utils since there are also other test related stuff there. These two Flavors could be called Settings and be made structs since they're just data
There was a problem hiding this comment.
also will you please make use of these in the other pcs files as well (either in this PR or a follow up PR)
| * | ||
| * @tparam Curve | ||
| */ | ||
| template <typename Curve> struct PCSInstanceWitnessGenerator { |
There was a problem hiding this comment.
Remove PCS in the name. Also I think this could use the Flavor/Settings defined in the other file
|
|
||
| const size_t num_unshifted = polynomials.size() - shiftable_polynomials.size(); | ||
|
|
||
| // Process polynomials that are not getting shifted |
There was a problem hiding this comment.
| // Process polynomials that are not getting shifted | |
| // Constructs polynomials that are not shifted |
| unshifted_evals.push_back(polynomials[idx].evaluate_mle(mle_opening_point)); | ||
| } | ||
|
|
||
| // Process polynomials that are getting shifted |
There was a problem hiding this comment.
| // Process polynomials that are getting shifted | |
| // Constructs polynomials that are being shifted |
| for (auto& poly : shiftable_polynomials) { | ||
| poly = Polynomial::random(n, /*shiftable*/ 1); | ||
| polynomials[idx] = poly; | ||
| auto comm = this->ck->commit(poly); |
| std::shared_ptr<typename TypeParam::CommitmentKey> ck; | ||
|
|
||
| auto prover_transcript = TypeParam::Transcript::prover_init_empty(); | ||
| ck = CreateCommitmentKey<typename TypeParam::CommitmentKey>(); |
There was a problem hiding this comment.
ditto to what I noted in the other test file
| SmallSubgroupIPA small_subgroup_ipa_prover = | ||
| SmallSubgroupIPA(zk_sumcheck_data, multivariate_challenge, claimed_inner_product, prover_transcript, ck); | ||
|
|
||
| auto batched_polynomial = small_subgroup_ipa_prover.get_batched_polynomial(); |
There was a problem hiding this comment.
avoid auto if posiblle and i think these are consts?
| TYPED_TEST_SUITE(SmallSubgroupIPATest, TestFlavors); | ||
|
|
||
| // Implement the tests | ||
| TYPED_TEST(SmallSubgroupIPATest, ProverComputationsCorrectness) |
There was a problem hiding this comment.
Will you add comments to what each TYPED_TEST is doing, please?
| } | ||
| }; | ||
|
|
||
| // Register the flavors for the test suite |
There was a problem hiding this comment.
comment not needed (ditto above) on line 60
|
|
||
| // Check that batched polynomial is divisible by Z_H(X) | ||
| bool ipa_claim_consistency = true; | ||
| for (size_t idx = 0; idx < SUBGROUP_SIZE; idx++) { |
This PR is a follow-up to #10773