Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in bicep path #109

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Fix bug in bicep path #109

merged 1 commit into from
Mar 21, 2024

Conversation

jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Mar 21, 2024

Pull Request

Issue

N/A

Description

Fix an incorrect path

Testing

You can see the Bicep tests passing here: https://github.com/Azure/accelerator-bootstrap-modules/actions/runs/8375595350

License

By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.

@jaredfholgate jaredfholgate self-assigned this Mar 21, 2024
@jaredfholgate jaredfholgate added bug Something isn't working Type: Bug 🪲 Something isn't working labels Mar 21, 2024
@jaredfholgate
Copy link
Member Author

Hi @oZakari. I found this bug in live when I ran the e2e tests. Will need to get the patch out ASAP.

Copy link
Contributor

@sebassem sebassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredfholgate
Copy link
Member Author

I am going to go ahead and merge this and release without an approving review given the bicep accelerator is currently broken.

@jaredfholgate jaredfholgate merged commit d131152 into main Mar 21, 2024
2 checks passed
@jaredfholgate jaredfholgate deleted the bug-bicep-directory-issue branch March 21, 2024 16:20
@oZakari
Copy link
Contributor

oZakari commented Mar 21, 2024

Thanks for jumping on that @jaredfholgate, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Type: Bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants