Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/quickstart for ado #3220
base: main
Are you sure you want to change the base?
Docs/quickstart for ado #3220
Changes from 2 commits
c1b430e
5cfb6ec
41fc60e
f339080
adcdd30
b6d39ed
b6cd711
1540d7a
47ea576
e225f13
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Publishing results in NUnit would require configuring
ps-rule.yaml
or setting options via environment variables. Also expansion needs to be enabled.We should add something similar to: https://azure.github.io/PSRule.Rules.Azure/quickstarts/test-bicep-with-github/#create-an-options-file
Maybe you can use the same markdown and add the adjustments for outputting results by setting options for
Output.Format
andOutput.Path
intops-rule.yaml
.https://microsoft.github.io/PSRule/v2/concepts/PSRule/en-US/about_PSRule_Options/#outputpath
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before I proceed with the updates, I’d like to confirm if I’m heading in the right direction:
Switch to NUnit for Test Results:
Should I update the pipeline to use
NUnit
instead ofJUnit
for publishing results? I’ll also ensure the results are outputted to.psrule-output/results.xml
.Update
ps-rule.yaml
Configuration:You mentioned configuring the
ps-rule.yaml
file. I plan to include the following settings:Output.Format: NUnit
Output.Path: .psrule-output/results.xml
Expand: true
to enable detailed rule explanations.Documentation Update:
I’ll update the quickstart guide to explain how to configure the
ps-rule.yaml
file with these settings, and also reference the relevant PSRule documentation.Is that aligned with what you were expecting?