Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use existing manifests for integration tests #485

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

jessejlt
Copy link
Member

There are two issues addressed in this PR.

  1. Remove the integration test's copy of the adx-mon component manifests in favor of utilizing the ones maintained for the quickstart.
  2. Integration tests were copying the component manifest's into k3s manifest directory, which means they were being treated as static pod manifests, which means we're unable to modify these components at runtime, thereby eliminating our ability to change the container image once created.

jessejlt and others added 2 commits December 19, 2024 20:24
There are two issues addressed in this PR.

1. Remove the integration test's copy of the adx-mon component manifests in favor of utilizing the ones maintained for the quickstart.
2. Integration tests were copying the component manifest's into k3s manifest directory, which means they were being treated as static pod manifests, which means we're unable to modify these components at runtime, thereby eliminating our ability to change the container image once created.
@jessejlt jessejlt merged commit 33f3b53 into main Dec 19, 2024
4 checks passed
@jessejlt jessejlt deleted the jesse/simplify-integration-tests branch December 19, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants