Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition metric writers away from accepting endpoint arg #505

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

mkeesey
Copy link
Contributor

@mkeesey mkeesey commented Jan 7, 2025

The writers we have used have de-facto only written to one endpoint. Some implementations such as the storage writer only ever supported one endpoint and ignored the endpoint argument provided to the Write method. This split was confusing and error prone.

Future work involves adding alternate forwarders which will use potentially different protocols than our normal collector to ingestor flow. Instead of metric collectors having one instance of a writer and multiple endpoints configured, these metric writers now have a collection of writers to send their data to.

The writers we have used have de-facto only written to one endpoint.
Some implementations such as the storage writer only ever supported one
endpoint and ignored the endpoint argument provided to the Write method.
This split was confusing and error prone.

Future work involves adding alternate forwarders which will use
potentially different protocols than our normal collector to ingestor
flow. Instead of metric collectors having one instance of a writer and
multiple endpoints configured, these metric writers now have a
collection of writers to send their data to.
@mkeesey mkeesey merged commit 035217c into main Jan 7, 2025
4 checks passed
@mkeesey mkeesey deleted the one-endpoint branch January 7, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants