Transition metric writers away from accepting endpoint arg #505
+67
−70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The writers we have used have de-facto only written to one endpoint. Some implementations such as the storage writer only ever supported one endpoint and ignored the endpoint argument provided to the Write method. This split was confusing and error prone.
Future work involves adding alternate forwarders which will use potentially different protocols than our normal collector to ingestor flow. Instead of metric collectors having one instance of a writer and multiple endpoints configured, these metric writers now have a collection of writers to send their data to.